chrome/browser/ui/cocoa/browser_window_controller.h - Issue 1412083002: Indicate in the Window menu which Chrome window has an active sound playing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.h

Issue 1412083002: Indicate in the Window menu which Chrome window has an active sound playing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: To show which Chromium window has an active/muted sound playing Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/browser_window_cocoa.mm ('K') | « chrome/browser/ui/cocoa/browser_window_cocoa.mm ('k') | chrome/browser/ui/cocoa/browser_window_controller.mm » ('j') | chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_controller.h

diff --git a/chrome/browser/ui/cocoa/browser_window_controller.h b/chrome/browser/ui/cocoa/browser_window_controller.h

index 957ba0c56a64169d9f83724ec559dfe881942559..b7c231e643f35e66c78ecada44f31d43fee199e4 100644

--- a/chrome/browser/ui/cocoa/browser_window_controller.h

+++ b/chrome/browser/ui/cocoa/browser_window_controller.h

@@ -15,6 +15,7 @@

#include "base/mac/scoped_nsobject.h"

#include "base/memory/scoped_ptr.h"

#include "chrome/browser/translate/chrome_translate_client.h"

+#include "chrome/browser/ui/tabs/tab_utils.h"

#import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h"

#import "chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h"

#import "chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller.h"

@@ -370,6 +371,9 @@ class Command;

- (void)executeExtensionCommand:(const std::string&)extension_id

command:(const extensions::Command&)command;

+- (void)setMediaState:(TabMediaState)media_state

Robert Sesek 2015/10/20 13:39:47 naming: In Objective-C, use camelCase, so mediaSta

Robert Sesek 2015/10/20 13:39:47 This needs a comment.

+ on:(content::WebContents*)contents;

Robert Sesek 2015/10/20 13:39:47 nit: align the colon after on: with the one after

@end // @interface BrowserWindowController