Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1416)

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm

Issue 1412083002: Indicate in the Window menu which Chrome window has an active sound playing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: put Emojis in generated_resources.grd Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm b/chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm
index 3ff2a87e7ab82e045b73aa449793fb8b8415642f..c0b5466a72f5e6c9c96387c9ee6893019149d835 100644
--- a/chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm
+++ b/chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm
@@ -11,11 +11,13 @@
#import "chrome/browser/ui/cocoa/browser_window_cocoa.h"
#import "chrome/browser/ui/cocoa/browser_window_controller.h"
#include "chrome/browser/ui/cocoa/cocoa_profile_test.h"
+#include "chrome/grit/generated_resources.h"
#include "chrome/test/base/testing_profile.h"
#include "content/public/browser/notification_details.h"
#include "testing/gtest/include/gtest/gtest.h"
#import "third_party/ocmock/OCMock/OCMock.h"
#import "third_party/ocmock/gtest_support.h"
+#include "ui/base/l10n/l10n_util_mac.h"
// Main test class.
class BrowserWindowCocoaTest : public CocoaProfileTest {
@@ -48,6 +50,28 @@ TEST_F(BrowserWindowCocoaTest, TestBookmarkBarVisible) {
EXPECT_EQ(before, bwc->IsBookmarkBarVisible());
}
+TEST_F(BrowserWindowCocoaTest, TestWindowTitle) {
+ scoped_ptr<BrowserWindowCocoa> bwc(
+ new BrowserWindowCocoa(browser(), controller_));
+ NSString* playingEmoji = l10n_util::GetNSString(IDS_WINDOW_AUDIO_PLAYING_MAC);
Robert Sesek 2015/10/28 18:45:57 naming: use under_scores (see other test file for
+ NSString* muteEmoji = l10n_util::GetNSString(IDS_WINDOW_AUDIO_MUTE_MAC);
+ EXPECT_EQ([bwc->GetWindowTitle() rangeOfString:playingEmoji].location,
+ NSNotFound);
+ EXPECT_EQ([bwc->GetWindowTitle() rangeOfString:muteEmoji].location,
+ NSNotFound);
+ bwc->UpdateMediaState(TAB_MEDIA_STATE_AUDIO_PLAYING);
+ EXPECT_NE([bwc->GetWindowTitle() rangeOfString:playingEmoji].location,
+ NSNotFound);
+ bwc->UpdateMediaState(TAB_MEDIA_STATE_AUDIO_MUTING);
+ EXPECT_NE([bwc->GetWindowTitle() rangeOfString:muteEmoji].location,
+ NSNotFound);
+ bwc->UpdateMediaState(TAB_MEDIA_STATE_NONE);
+ EXPECT_EQ([bwc->GetWindowTitle() rangeOfString:playingEmoji].location,
+ NSNotFound);
+ EXPECT_EQ([bwc->GetWindowTitle() rangeOfString:muteEmoji].location,
+ NSNotFound);
+}
+
// Test that IsMaximized() returns false when the browser window goes from
// maximized to minimized state - http://crbug/452976.
TEST_F(BrowserWindowCocoaTest, TestMinimizeState) {

Powered by Google App Engine
This is Rietveld 408576698