Indicate in the Window menu which Chrome window has an active sound playing

chrome/browser/ui/cocoa/browser_window_cocoa.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/browser_window_cocoa.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/logging.h"
 #import "base/mac/sdk_forward_declarations.h"
@@ skipping 70 matching lines @@
 // Used for defining the layout of the NSAlert and NSTextField within the
 // accessory view.
 const int kAppTextFieldVerticalSpacing = 2;
 const int kAppTextFieldWidth = 200;
 const int kAppTextFieldHeight = 22;
 const int kBookmarkAppBubbleViewWidth = 200;
 const int kBookmarkAppBubbleViewHeight = 46;
 
 const int kIconPreviewTargetSize = 128;
 
+const char kWhiteSpaceCharacter = ' ';
+
 base::string16 TrimText(NSString* controlText) {
   base::string16 text = base::SysNSStringToUTF16(controlText);
   base::TrimWhitespace(text, base::TRIM_ALL, &text);
   return text;
 }
 
 }  // namespace
 
 @interface TextRequiringDelegate : NSObject<NSTextFieldDelegate> {
  @private
@@ skipping 191 matching lines @@
 }
 
 StatusBubble* BrowserWindowCocoa::GetStatusBubble() {
   return [controller_ statusBubble];
 }
 
 void BrowserWindowCocoa::UpdateTitleBar() {
   NSString* newTitle =
       base::SysUTF16ToNSString(browser_->GetWindowTitleForCurrentTab());
 
+  NSMutableString* titleWithMediaState = [NSMutableString string];

[Robert Sesek, 2015/10/22 00:01:52]

Use [NSMutableString stringWithString:] to avoid unnecessary copying/resizing.

+  [titleWithMediaState appendString:newTitle];
+
+  if (media_state_ == TAB_MEDIA_STATE_AUDIO_PLAYING) {
+    [titleWithMediaState appendFormat:@"%c", kWhiteSpaceCharacter];

[miu, 2015/10/21 20:06:52]

Can the whitespace char be included in the string resource?  Perhaps it should
be a non-breaking space instead of a plain ASCII space char?  Though, the Cocoa
experts probably know better than me here.  ;-)

+    [titleWithMediaState appendString:@"🔊"];

[miu, 2015/10/21 20:06:52]

Was this moved to generated_resources.prd?  If so, please upload the updated
patch.

[Robert Sesek, 2015/10/22 00:01:52]

Two appends shouldn't be necessary. Just  [title appendFormat:@"%c <emoji>",
kWhiteSpaceCharacter]

+  }
+  else if (media_state_ ==  TAB_MEDIA_STATE_AUDIO_MUTING) {

[Robert Sesek, 2015/10/22 00:01:52]

nit: this goes on line 310.

+    [titleWithMediaState appendFormat:@"%c", kWhiteSpaceCharacter];
+    [titleWithMediaState appendString:@"🔇"];
+  }
+
   pending_window_title_.reset(
       [BrowserWindowUtils scheduleReplaceOldTitle:pending_window_title_.get()
-                                     withNewTitle:newTitle
+                                     withNewTitle:titleWithMediaState
                                         forWindow:window()]);
 }
 
+void BrowserWindowCocoa::UpdateMediaState(TabMediaState media_state) {
+  media_state_ = media_state;
+  UpdateTitleBar();
+}
+
 void BrowserWindowCocoa::BookmarkBarStateChanged(
     BookmarkBar::AnimateChangeType change_type) {
   [[controller_ bookmarkBarController]
       updateState:browser_->bookmark_bar_state()
        changeType:change_type];
 }
 
 void BrowserWindowCocoa::UpdateDevTools() {
   [controller_ updateDevToolsForContents:
       browser_->tab_strip_model()->GetActiveWebContents()];
@@ skipping 536 matching lines @@
 void BrowserWindowCocoa::UnhideDownloadShelf() {
   GetDownloadShelf()->Unhide();
 }
 
 void BrowserWindowCocoa::HideDownloadShelf() {
   GetDownloadShelf()->Hide();
   StatusBubble* statusBubble = GetStatusBubble();
   if (statusBubble)
     statusBubble->Hide();
 }