Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 1412063012: Revert of [heap] Separate out optimized code map processing. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Separate out optimized code map processing. (patchset #2 id:20001 of https://codereview.chromium.org/1421903012/ ) Reason for revert: Causes GC-Stress failures. Original issue's description: > [heap] Separate out optimized code map processing. > > This separates the post-processing step for optimized code maps out of > the CodeFlusher. It uses the complete SharedFunctionInfo::Iterator to > visit all candidates instead of gathering candidates during marking. > > Gathering candidates during marking no longer makes sense, now that the > majority of SharedFunctionInfo objects will hold such an optimized code > map. Also it reduces complexity of the implementation. Also conflating > this mechanism with "code flushing" was confusing. > > This reverts commit b6644e849151dedffc1844d60b7a76da4d9e5115. > > R=ulan@chromium.org > > Committed: https://crrev.com/bb7a5eb2d89bae25f2b5ecb9515669f0ac73c111 > Cr-Commit-Position: refs/heads/master@{#31836} TBR=ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/7f1fb29faa4fe8ebd39d69fdfcdd1f2a3ac09579 Cr-Commit-Position: refs/heads/master@{#31837}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1276 lines, -1192 lines) Patch
M src/heap/gc-tracer.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/gc-tracer.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/heap/mark-compact.h View 5 chunks +19 lines, -9 lines 0 comments Download
M src/heap/mark-compact.cc View 3 chunks +1204 lines, -1148 lines 0 comments Download
M src/heap/mark-compact-inl.h View 2 chunks +28 lines, -0 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 2 chunks +12 lines, -13 lines 0 comments Download
M src/objects.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/objects.cc View 1 chunk +10 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
Created Revert of [heap] Separate out optimized code map processing.
5 years, 1 month ago (2015-11-05 18:49:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412063012/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412063012/1
5 years, 1 month ago (2015-11-05 18:49:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-05 18:50:02 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 18:50:49 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f1fb29faa4fe8ebd39d69fdfcdd1f2a3ac09579
Cr-Commit-Position: refs/heads/master@{#31837}

Powered by Google App Engine
This is Rietveld 408576698