Issue 1412013008: Make unit_test compile on Android & GN part 1/2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1412013008: Make unit_test compile on Android & GN part 1/2 (Closed)

Created:
5 years, 1 month ago by pkotwicz

Modified:
5 years, 1 month ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Make unit_test compile on Android & GN part 1/2 BUG=510485 Committed: https://crrev.com/a9cf89b9a012c494635863f8f0fb228b7971fc35 Cr-Commit-Position: refs/heads/master@{#357139}

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -7 lines)			Patch
	M	chrome/chrome_tests_unit.gypi	View		2 chunks	+8 lines, -6 lines	0 comments	Download
	M	chrome/test/BUILD.gn	View		3 chunks	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

pkotwicz

Scott, can you please take a look? Part 2 is to remove the "unit_tests" target ...

5 years, 1 month ago (2015-10-30 16:39:21 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412013008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412013008/1

5 years, 1 month ago (2015-10-30 17:43:51 UTC) #5

commit-bot: I haz the power

5 years, 1 month ago (2015-10-30 18:33:53 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/a9cf89b9a012c494635863f8f0fb228b7971fc35
Cr-Commit-Position: refs/heads/master@{#357139}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages