Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issue 1411963006: [SkDebugger] Remove unneeded SkDebuggerGUI includes (Closed)

Created:
5 years, 1 month ago by f(malita)
Modified:
5 years, 1 month ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M debugger/QT/SkDebuggerGUI.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
f(malita)
Fixes this build borkage locally: FAILED: c++ -MMD -MF obj/debugger/QT/debugger.SkDebuggerGUI.o.d -DSK_INTERNAL -DSK_GAMMA_SRGB -DSK_GAMMA_APPLY_TO_A8 -DSK_ALLOW_STATIC_GLOBAL_INITIALIZERS=1 -DSK_SUPPORT_GPU=1 ...
5 years, 1 month ago (2015-11-02 17:22:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411963006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411963006/1
5 years, 1 month ago (2015-11-02 17:22:26 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 1 month ago (2015-11-02 17:22:27 UTC) #4
robertphillips
lgtm
5 years, 1 month ago (2015-11-02 17:24:11 UTC) #5
mtklein
wtf, lgtm
5 years, 1 month ago (2015-11-02 17:31:14 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 17:32:57 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3f0424ff57f93666df7347d4787816b210233eb0

Powered by Google App Engine
This is Rietveld 408576698