Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 1411933005: Establish an invariant on initial maps: (Closed)

Created:
5 years, 1 month ago by Igor Sheludko
Modified:
5 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Establish an invariant on initial maps: 1) they always own descriptors, 2) the number of own descriptors is equal to the number of descriptors in the descriptor array. This allows an initial map of a subclass to share descriptor array with initial map of the parent class (if it already contains properties). BUG=chromium:551430 LOG=N Committed: https://crrev.com/2ed1749091b91f0c8aef6d555f13d14e4089747f Cr-Commit-Position: refs/heads/master@{#31892}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -21 lines) Patch
M src/objects.cc View 8 chunks +41 lines, -21 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411933005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411933005/1
5 years, 1 month ago (2015-11-06 14:08:44 UTC) #2
Igor Sheludko
PTAL
5 years, 1 month ago (2015-11-06 14:08:59 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-06 14:26:05 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411933005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411933005/20001
5 years, 1 month ago (2015-11-06 18:32:38 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-06 19:19:18 UTC) #12
Toon Verwaest
lgtm
5 years, 1 month ago (2015-11-09 16:08:53 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411933005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411933005/20001
5 years, 1 month ago (2015-11-09 16:10:07 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 1 month ago (2015-11-09 16:26:58 UTC) #16
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 16:27:23 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ed1749091b91f0c8aef6d555f13d14e4089747f
Cr-Commit-Position: refs/heads/master@{#31892}

Powered by Google App Engine
This is Rietveld 408576698