Propagate drag-and-drop key modifiers to WebView's guest renderer.

Propagate drag-and-drop key modifiers to WebView's guest renderer.

Currently BrowserPluginGuest strips drag event modifiers when forwarding
the events to the guest renderer, which is wrong.

This CL provides the necessary plumbing to propagate these modifiers.

BUG=545315
Committed: https://crrev.com/0562edfce0c9521d38c1105f4dc7b15806746c58
Cr-Commit-Position: refs/heads/master@{#394157}

[wjmaclean, 2015-11-04 16:12:07]

** Small CL **

rbyers@ - Please look at WebKit changes.
creis@ - Please look at content/ changes.

[wjmaclean, 2015-11-04 16:12:16]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-04 16:12:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411913010/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411913010/1

[wjmaclean, 2015-11-04 16:39:05]

Description was changed from

==========
Propagate key modifiers to WebView's guest renderer.

Currently BrowserPluginGuest strips drag event modifiers when forwarding
the events to the guest renderer, which is wrong.

This CL provides the necessary plumbing to propagate these modifiers.

BUG=545315
==========

to

==========
Propagate key modifiers to WebView's guest renderer.

Currently BrowserPluginGuest strips drag event modifiers when forwarding
the events to the guest renderer, which is wrong.

This CL provides the necessary plumbing to propagate these modifiers.

BUG=545315
==========

[wjmaclean, 2015-11-04 16:39:05]

wjmaclean@chromium.org changed reviewers:
+ creis@chromium.org, rbyers@chromium.org

[wjmaclean, 2015-11-04 16:39:41]

** small CL **

creis@ - Please look at changes in content/
rbyers@ - Please look at changes in WebKit/

[Rick Byers, 2015-11-04 17:19:54]

WebKit changes look fine, but can't you test this somehow?

[wjmaclean, 2015-11-04 17:59:45]

On 2015/11/04 17:19:54, Rick Byers wrote:
> WebKit changes look fine, but can't you test this somehow?

Yeah, I'm trying to figure out a meaningful way to test this ... will add
something to the CL when I come up with it ...

[commit-bot: I haz the power, 2015-11-04 19:09:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-04 19:09:10]

Dry run: This issue passed the CQ dry run.

[Charlie Reis, 2015-11-04 22:48:29]

+1 to a test if you can.  Otherwise content/ LGTM with nits.

nit: Mention something about drag n drop in the CL subject?  It's not clear
that's the context at first.

https://codereview.chromium.org/1411913010/diff/1/content/public/common/drop_...
File content/public/common/drop_data.h (right):

https://codereview.chromium.org/1411913010/diff/1/content/public/common/drop_...
content/public/common/drop_data.h:43: int key_modifiers;
If this is temporary, maybe it should go at the end?

https://codereview.chromium.org/1411913010/diff/1/content/public/common/drop_...
content/public/common/drop_data.h:81: 
nit: Not needed.

[wjmaclean, 2015-11-05 15:03:56]

Description was changed from

==========
Propagate key modifiers to WebView's guest renderer.

Currently BrowserPluginGuest strips drag event modifiers when forwarding
the events to the guest renderer, which is wrong.

This CL provides the necessary plumbing to propagate these modifiers.

BUG=545315
==========

to

==========
Propagate drag-and-drop key modifiers to WebView's guest renderer.

Currently BrowserPluginGuest strips drag event modifiers when forwarding
the events to the guest renderer, which is wrong.

This CL provides the necessary plumbing to propagate these modifiers.

BUG=545315
==========

[wjmaclean, 2015-11-05 15:08:07]

Updated with creis@'s suggestions.

I'm still working on a test: my hope is to parameterize
WebViewInteractiveTest.DragDropWithinWebView so that it runs twice, once without
a modifier, and once with the shift-key modifier.

It's proving a little tricky adding the modifier with the way the test is
currently structured, but I'm hopeful I can get something reasonable figured
out.

https://codereview.chromium.org/1411913010/diff/1/content/public/common/drop_...
File content/public/common/drop_data.h (right):

https://codereview.chromium.org/1411913010/diff/1/content/public/common/drop_...
content/public/common/drop_data.h:43: int key_modifiers;
On 2015/11/04 22:48:29, Charlie Reis (slow til 11-16) wrote:
> If this is temporary, maybe it should go at the end?

Done. (I had chosen this location primarily to keep the 'primitive data types'
together, but I'm fine with it at the end as well.)

https://codereview.chromium.org/1411913010/diff/1/content/public/common/drop_...
content/public/common/drop_data.h:81: 
On 2015/11/04 22:48:29, Charlie Reis (slow til 11-16) wrote:
> nit: Not needed.

Done.

[Rick Byers, 2016-05-17 13:58:02]

Is this CL still active?  Just scrubbing my to-review list...

[wjmaclean, 2016-05-17 14:11:55]

On 2016/05/17 13:58:02, Rick Byers wrote:
> Is this CL still active?  Just scrubbing my to-review list...

It's active in the sense that it would still be nice to plumb this data through,
but the current testing infrastructure makes it very difficult to test ... as
it's a lower priority, it's been on the back-burner.

[Rick Byers, 2016-05-17 14:26:23]

If it's hard to test, then I'm fine landing it without a test - it's just simple
plumbing.  WebKit LGTM

[wjmaclean, 2016-05-17 15:31:13]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-17 15:31:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411913010/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411913010/40001

[wjmaclean, 2016-05-17 15:40:32]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-17 15:40:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411913010/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411913010/60001

[commit-bot: I haz the power, 2016-05-17 17:08:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 17:08:34]

Dry run: This issue passed the CQ dry run.

[wjmaclean, 2016-05-17 17:35:56]

The CQ bit was checked by wjmaclean@chromium.org

[wjmaclean, 2016-05-17 17:35:57]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org,
rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/1411913010/#ps60001
(title: "Fix initialiser order.")

[commit-bot: I haz the power, 2016-05-17 17:36:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411913010/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411913010/60001

[commit-bot: I haz the power, 2016-05-17 17:40:59]

Description was changed from

==========
Propagate drag-and-drop key modifiers to WebView's guest renderer.

Currently BrowserPluginGuest strips drag event modifiers when forwarding
the events to the guest renderer, which is wrong.

This CL provides the necessary plumbing to propagate these modifiers.

BUG=545315
==========

to

==========
Propagate drag-and-drop key modifiers to WebView's guest renderer.

Currently BrowserPluginGuest strips drag event modifiers when forwarding
the events to the guest renderer, which is wrong.

This CL provides the necessary plumbing to propagate these modifiers.

BUG=545315
==========

[commit-bot: I haz the power, 2016-05-17 17:41:01]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-17 17:42:11]

Description was changed from

==========
Propagate drag-and-drop key modifiers to WebView's guest renderer.

Currently BrowserPluginGuest strips drag event modifiers when forwarding
the events to the guest renderer, which is wrong.

This CL provides the necessary plumbing to propagate these modifiers.

BUG=545315
==========

to

==========
Propagate drag-and-drop key modifiers to WebView's guest renderer.

Currently BrowserPluginGuest strips drag event modifiers when forwarding
the events to the guest renderer, which is wrong.

This CL provides the necessary plumbing to propagate these modifiers.

BUG=545315

Committed: https://crrev.com/0562edfce0c9521d38c1105f4dc7b15806746c58
Cr-Commit-Position: refs/heads/master@{#394157}
==========

[commit-bot: I haz the power, 2016-05-17 17:42:12]

Patchset 4 (id:??) landed as
https://crrev.com/0562edfce0c9521d38c1105f4dc7b15806746c58
Cr-Commit-Position: refs/heads/master@{#394157}