Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 1411873005: Start remove dependencies on compiler-related files. (Closed)

Created:
5 years, 1 month ago by Florian Schneider
Modified:
5 years, 1 month ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Start remove dependencies on compiler-related files. Minimize the number of dependencies of compiler-related files. This is needed to remove whole .cc/.h files from a compiler-less VM binary which can be used for running precompiled code. * removed dependencies of object.cc on flow_graph_compiler.h and flow_graph_builder.h * removed unnecessary includes from object.h BUG= R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/f6b96b3d07879172f084cd3ae4ead4f337cb21a6

Patch Set 1 #

Patch Set 2 : removed some unnecessry includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -61 lines) Patch
M runtime/vm/flow_graph_builder.h View 1 chunk +0 lines, -28 lines 0 comments Download
M runtime/vm/flow_graph_compiler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/method_recognizer.h View 1 chunk +27 lines, -0 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/object.cc View 1 3 chunks +0 lines, -23 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
5 years, 1 month ago (2015-11-04 21:02:43 UTC) #3
srdjan
lgtm
5 years, 1 month ago (2015-11-04 22:09:22 UTC) #4
Florian Schneider
5 years, 1 month ago (2015-11-04 23:08:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f6b96b3d07879172f084cd3ae4ead4f337cb21a6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698