src/compiler/ast-loop-assignment-analyzer.cc - Issue 1411873004: [es6] allow any LeftHandSideExpression in for-of loops

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/ast-loop-assignment-analyzer.cc

Issue 1411873004: [es6] allow any LeftHandSideExpression in for-of loops (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix bug in loop-assignment-analyzer which resulted in incorrect code Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/ast-loop-assignment-analyzer.cc

diff --git a/src/compiler/ast-loop-assignment-analyzer.cc b/src/compiler/ast-loop-assignment-analyzer.cc

index 00ca1b341b6f8ecfd68d1101a807b17e25003bec..040999aa05133ea809bde0ae674f9df7d74e9b60 100644

--- a/src/compiler/ast-loop-assignment-analyzer.cc

+++ b/src/compiler/ast-loop-assignment-analyzer.cc

@@ -261,7 +261,9 @@ void ALAA::VisitForInStatement(ForInStatement* loop) {

void ALAA::VisitForOfStatement(ForOfStatement* loop) {

+ Visit(loop->assign_iterator());

Enter(loop);

+ Visit(loop->assign_each());

Visit(loop->each());

Visit(loop->subject());

Visit(loop->body());

« no previous file with comments | « no previous file | src/parser.cc » ('j') | no next file with comments »