chrome/browser/resources/options/browser_options.html - Issue 1411863002: Use kMetricsReportingEnabled instead of kStatsReporingPref on metrics side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/browser_options.html

Issue 1411863002: Use kMetricsReportingEnabled instead of kStatsReporingPref on metrics side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Delete settings pref ref from priviate_api + Added comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/metrics_reporting_state.cc ('K') | « chrome/browser/profiles/profile_io_data.cc ('k') | chrome/browser/resources/options/browser_options.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/browser_options.html

diff --git a/chrome/browser/resources/options/browser_options.html b/chrome/browser/resources/options/browser_options.html

index 01c30dce66490a3be30b3cc77711bcee02314701..d3c966791166880842276e50b66c8c206fcab67b 100644

--- a/chrome/browser/resources/options/browser_options.html

+++ b/chrome/browser/resources/options/browser_options.html

@@ -432,18 +432,6 @@

<div id="metrics-reporting-setting"

class="checkbox controlled-setting-with-label">

-<if expr="chromeos">

- <label>

- <input id="metrics-reporting-enabled"

- pref="cros.metrics.reportingEnabled" type="checkbox">

- <span>

- <span i18n-content="enableLogging"></span>

- <span class="controlled-setting-indicator"

- pref="cros.metrics.reportingEnabled"></span>

- </span>

- </label>

-</if>

-<if expr="not chromeos">

<label>

<span>

@@ -452,12 +440,13 @@

class="controlled-setting-indicator"></span>

</span>

</label>

+<if expr="not chromeos">

<span></span><a is="action-link" role="button"

class="standalone-action-link"></a><span></span>

</span>

-</if>

+</if>

</div>

</if>