Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1869)

Unified Diff: chrome/browser/policy/configuration_policy_handler_list_factory.cc

Issue 1411863002: Use kMetricsReportingEnabled instead of kStatsReporingPref on metrics side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Delete settings pref ref from priviate_api + Added comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/configuration_policy_handler_list_factory.cc
diff --git a/chrome/browser/policy/configuration_policy_handler_list_factory.cc b/chrome/browser/policy/configuration_policy_handler_list_factory.cc
index 5568846d75bfac6ff31a69ee797bf669bb4e8692..9f104dcf4b0587c4bde0858f11bde0d175aefbbb 100644
--- a/chrome/browser/policy/configuration_policy_handler_list_factory.cc
+++ b/chrome/browser/policy/configuration_policy_handler_list_factory.cc
@@ -122,9 +122,6 @@ const PolicyToPreferenceMapEntry kSimplePolicyMap[] = {
{ key::kDisablePrintPreview,
prefs::kPrintPreviewDisabled,
base::Value::TYPE_BOOLEAN },
- { key::kMetricsReportingEnabled,
- metrics::prefs::kMetricsReportingEnabled,
- base::Value::TYPE_BOOLEAN },
{ key::kApplicationLocaleValue,
prefs::kApplicationLocale,
base::Value::TYPE_STRING },
@@ -483,6 +480,17 @@ const PolicyToPreferenceMapEntry kSimplePolicyMap[] = {
base::Value::TYPE_BOOLEAN },
#endif // defined(OS_CHROMEOS)
+// Metrics reporting is controlled by a platform specific policy for ChromeOS
+#if defined(OS_CHROMEOS)
+ { key::kDeviceMetricsReportingEnabled,
+ metrics::prefs::kMetricsReportingEnabled,
+ base::Value::TYPE_BOOLEAN },
+#else
+ { key::kMetricsReportingEnabled,
+ metrics::prefs::kMetricsReportingEnabled,
+ base::Value::TYPE_BOOLEAN },
+#endif
+
#if !defined(OS_MACOSX) && !defined(OS_CHROMEOS)
{ key::kBackgroundModeEnabled,
prefs::kBackgroundModeEnabled,

Powered by Google App Engine
This is Rietveld 408576698