chrome/browser/extensions/api/settings_private/prefs_util.cc - Issue 1411863002: Use kMetricsReportingEnabled instead of kStatsReporingPref on metrics side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/settings_private/prefs_util.cc

Issue 1411863002: Use kMetricsReportingEnabled instead of kStatsReporingPref on metrics side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Delete settings pref ref from priviate_api + Added comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/login/wizard_controller.cc ('K') | « chrome/browser/chromeos/settings/stub_cros_settings_provider.cc ('k') | chrome/browser/metrics/chrome_metrics_service_accessor.cc » ('j') | chrome/browser/metrics/metrics_reporting_state.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/settings_private/prefs_util.cc

diff --git a/chrome/browser/extensions/api/settings_private/prefs_util.cc b/chrome/browser/extensions/api/settings_private/prefs_util.cc

index 11612f213ef705b3c6c09681ad2a3bdeb00ac8bc..8f00588b58bfd4f40751b96a5d0e8c930760ef85 100644

--- a/chrome/browser/extensions/api/settings_private/prefs_util.cc

+++ b/chrome/browser/extensions/api/settings_private/prefs_util.cc

@@ -150,8 +150,6 @@ const PrefsUtil::TypedPrefMap& PrefsUtil::GetWhitelistedKeys() {

settings_private::PrefType::PREF_TYPE_STRING;

(*s_whitelist)["settings.touchpad.enable_tap_dragging"] =

settings_private::PrefType::PREF_TYPE_BOOLEAN;

- (*s_whitelist)["cros.metrics.reportingEnabled"] =

- settings_private::PrefType::PREF_TYPE_BOOLEAN;

(*s_whitelist)["cros.device.attestation_for_content_protection_enabled"] =

settings_private::PrefType::PREF_TYPE_BOOLEAN;

(*s_whitelist)["settings.internet.wake_on_wifi_ssid"] =