chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc - Issue 1411863002: Use kMetricsReportingEnabled instead of kStatsReporingPref on metrics side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc

Issue 1411863002: Use kMetricsReportingEnabled instead of kStatsReporingPref on metrics side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Delete settings pref ref from priviate_api + Added comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/login/wizard_controller.cc ('K') | « chrome/browser/chromeos/login/wizard_controller.cc ('k') | chrome/browser/chromeos/settings/device_settings_provider.h » ('j') | chrome/browser/metrics/metrics_reporting_state.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc

diff --git a/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc b/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc

index 6a4ba6d3f9f3ab39118d875e19a7704240040fb4..68006d51d0e7f62d49ba24cba0e71c1d90233b7c 100644

--- a/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc

+++ b/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc

@@ -618,13 +618,6 @@ void OwnerSettingsServiceChromeOS::UpdateDeviceSettings(

release_channel->set_release_channel(channel_value);

else

NOTREACHED();

- } else if (path == kStatsReportingPref) {

- em::MetricsEnabledProto* metrics = settings.mutable_metrics_enabled();

- bool metrics_value = false;

- if (value.GetAsBoolean(&metrics_value))

- metrics->set_metrics_enabled(metrics_value);

- else

- NOTREACHED();

} else if (path == kAccountsPrefUsers) {

em::UserWhitelistProto* whitelist_proto = settings.mutable_user_whitelist();

whitelist_proto->clear_user_whitelist();