Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: chrome/browser/resources/options/browser_options.html

Issue 1411863002: Use kMetricsReportingEnabled instead of kStatsReporingPref on metrics side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <div id="settings" class="page" hidden> 1 <div id="settings" class="page" hidden>
2 <header> 2 <header>
3 <h1 i18n-content="settingsTitle"></h1> 3 <h1 i18n-content="settingsTitle"></h1>
4 </header> 4 </header>
5 <include src="reset_profile_settings_banner.html"> 5 <include src="reset_profile_settings_banner.html">
6 <include src="automatic_settings_reset_banner.html"> 6 <include src="automatic_settings_reset_banner.html">
7 <if expr="chromeos"> 7 <if expr="chromeos">
8 <link rel="import" href="chrome://resources/cr_elements/network/cr_network_ico n.html"> 8 <link rel="import" href="chrome://resources/cr_elements/network/cr_network_ico n.html">
9 <link rel="import" href="chrome://resources/cr_elements/network/cr_onc_types.h tml"> 9 <link rel="import" href="chrome://resources/cr_elements/network/cr_onc_types.h tml">
10 <include src="secondary_user_banner.html"> 10 <include src="secondary_user_banner.html">
(...skipping 414 matching lines...) Expand 10 before | Expand all | Expand 10 after
425 <span i18n-content="spellingPref"></span> 425 <span i18n-content="spellingPref"></span>
426 <span id="spelling-enabled-indicator" 426 <span id="spelling-enabled-indicator"
427 class="controlled-setting-indicator" 427 class="controlled-setting-indicator"
428 pref="spellcheck.use_spelling_service" dialog-pref> 428 pref="spellcheck.use_spelling_service" dialog-pref>
429 </span> 429 </span>
430 </label> 430 </label>
431 </div> 431 </div>
432 <if expr="_google_chrome"> 432 <if expr="_google_chrome">
433 <div id="metrics-reporting-setting" 433 <div id="metrics-reporting-setting"
434 class="checkbox controlled-setting-with-label"> 434 class="checkbox controlled-setting-with-label">
435 <if expr="chromeos">
436 <label>
437 <input id="metrics-reporting-enabled"
438 pref="cros.metrics.reportingEnabled" type="checkbox">
439 <span>
440 <span i18n-content="enableLogging"></span>
441 <span class="controlled-setting-indicator"
442 pref="cros.metrics.reportingEnabled"></span>
443 </span>
444 </label>
445 </if>
446 <if expr="not chromeos">
447 <label> 435 <label>
448 <input id="metrics-reporting-enabled" type="checkbox"> 436 <input id="metrics-reporting-enabled" type="checkbox">
449 <span> 437 <span>
450 <span i18n-content="enableLogging"></span> 438 <span i18n-content="enableLogging"></span>
451 <span id="metrics-reporting-disabled-icon" 439 <span id="metrics-reporting-disabled-icon"
452 class="controlled-setting-indicator"></span> 440 class="controlled-setting-indicator"></span>
453 </span> 441 </span>
454 </label> 442 </label>
443 <if expr="not chromeos">
455 <span id="metrics-reporting-reset-restart" hidden> 444 <span id="metrics-reporting-reset-restart" hidden>
456 <!-- Text filled by JavaScript --> 445 <!-- Text filled by JavaScript -->
457 <span></span><a is="action-link" role="button" 446 <span></span><a is="action-link" role="button"
458 class="standalone-action-link"></a><span></span> 447 class="standalone-action-link"></a><span></span>
459 </span> 448 </span>
460 </if> 449 </if> <!-- not chromeos -->
461 </div> 450 </div>
462 </if> <!-- _google_chrome --> 451 </if> <!-- _google_chrome -->
463 <div class="checkbox"> 452 <div class="checkbox">
464 <label> 453 <label>
465 <input id="do-not-track-enabled" pref="enable_do_not_track" 454 <input id="do-not-track-enabled" pref="enable_do_not_track"
466 metric="Options_DoNotTrackCheckbox" type="checkbox" dialog-pref> 455 metric="Options_DoNotTrackCheckbox" type="checkbox" dialog-pref>
467 <span i18n-content="doNotTrack"></span> 456 <span i18n-content="doNotTrack"></span>
468 </label> 457 </label>
469 </div> 458 </div>
470 <if expr="chromeos"> 459 <if expr="chromeos">
(...skipping 556 matching lines...) Expand 10 before | Expand all | Expand 10 after
1027 </button> 1016 </button>
1028 </div> 1017 </div>
1029 </section> 1018 </section>
1030 </div> <!-- advanced-settings-container --> 1019 </div> <!-- advanced-settings-container -->
1031 </div> <!-- advanced-settings --> 1020 </div> <!-- advanced-settings -->
1032 <footer id="advanced-settings-footer"> 1021 <footer id="advanced-settings-footer">
1033 <a is="action-link" id="advanced-settings-expander" 1022 <a is="action-link" id="advanced-settings-expander"
1034 i18n-content="showAdvancedSettings"></a> 1023 i18n-content="showAdvancedSettings"></a>
1035 </footer> 1024 </footer>
1036 </div> 1025 </div>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698