Use kMetricsReportingEnabled instead of kStatsReporingPref on metrics side

chrome/browser/chromeos/settings/device_settings_provider.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_SETTINGS_DEVICE_SETTINGS_PROVIDER_H_
 #define CHROME_BROWSER_CHROMEOS_SETTINGS_DEVICE_SETTINGS_PROVIDER_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 34 matching lines @@
                          DeviceSettingsService* device_settings_service);
   ~DeviceSettingsProvider() override;
 
   // Returns true if |path| is handled by this provider.
   static bool IsDeviceSetting(const std::string& name);
 
   // CrosSettingsProvider implementation.
   const base::Value* Get(const std::string& path) const override;
   TrustedStatus PrepareTrustedValues(const base::Closure& callback) override;
   bool HandlesSetting(const std::string& path) const override;
+  void SetPrefForTesting(const std::string& path, bool value);
 
  private:
   // CrosSettingsProvider implementation:
   void DoSet(const std::string& path, const base::Value& value) override;
 
   // DeviceSettingsService::Observer implementation:
   void OwnershipStatusChanged() override;
   void DeviceSettingsUpdated() override;
   void OnDeviceSettingsServiceShutdown() override;
 
   // ownership::OwnerSettingsService::Observer implementation:
   void OnTentativeChangesInPolicy(
       const enterprise_management::PolicyData& policy_data) override;
 
   // Populates in-memory cache from the local_state cache that is used to store
   // device settings before the device is owned and to speed up policy
   // availability before the policy blob is fetched on boot.
   void RetrieveCachedData();
 
   // Parses the policy data and fills in |values_cache_|.
   void UpdateValuesCache(
       const enterprise_management::PolicyData& policy_data,
       const enterprise_management::ChromeDeviceSettingsProto& settings,
       TrustedStatus trusted_status);
 
-  // Applies the metrics policy and if not set migrates the legacy file.
-  void ApplyMetricsSetting(bool use_file, bool new_value);
-
   // Applies the data roaming policy.
   void ApplyRoamingSetting(bool new_value);
   void ApplyRoamingSettingFromProto(
       const enterprise_management::ChromeDeviceSettingsProto& settings);
 
-  // Applies any changes of the policies that are not handled by the respective
-  // subsystems.
-  void ApplySideEffects(
-      const enterprise_management::ChromeDeviceSettingsProto& settings);
-
   // In case of missing policy blob we should verify if this is upgrade of
   // machine owned from pre version 12 OS and the user never touched the device
   // settings. In this case revert to defaults and let people in until the owner
   // comes and changes that.
   bool MitigateMissingPolicy();
 
   // Checks if the current cache value can be trusted for being representative
   // for the disk cache.
   TrustedStatus RequestTrustedEntity();
 
   // Invokes UpdateFromService() to synchronize with |device_settings_service_|,
   // then triggers the next store operation if applicable.
   void UpdateAndProceedStoring();
 
   // Re-reads state from |device_settings_service_|, adjusts
   // |trusted_status_| and calls UpdateValuesCache() if applicable. Returns true
   // if new settings have been loaded.
   bool UpdateFromService();
 
-  // Checks the current ownership status to see whether the device owner is
-  // logged in and writes the data accumulated in |migration_values_| to proper
-  // device settings.
-  void AttemptMigration();
-
   // Pending callbacks that need to be invoked after settings verification.
   std::vector<base::Closure> callbacks_;
 
   DeviceSettingsService* device_settings_service_;
   mutable PrefValueMap migration_values_;
 
   TrustedStatus trusted_status_;
   DeviceSettingsService::OwnershipStatus ownership_status_;
 
   // The device settings as currently reported through the
@@ skipping 17 matching lines @@
                            InitializationTestUnowned);
   FRIEND_TEST_ALL_PREFIXES(DeviceSettingsProviderTest,
                            PolicyFailedPermanentlyNotification);
   FRIEND_TEST_ALL_PREFIXES(DeviceSettingsProviderTest, PolicyLoadNotification);
   DISALLOW_COPY_AND_ASSIGN(DeviceSettingsProvider);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_SETTINGS_DEVICE_SETTINGS_PROVIDER_H_