Use kMetricsReportingEnabled instead of kStatsReporingPref on metrics side

chromeos/settings/cros_settings_names.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/settings/cros_settings_names.h"
 
 namespace chromeos {
 
 const char kCrosSettingsPrefix[] = "cros.";
 
@@ skipping 50 matching lines @@
 // the policy's value on logout.
 const char kSystemTimezone[] = "cros.system.timezone";
 const char kSystemTimezonePolicy[] = "cros.system.timezone_policy";
 
 // Value of kUse24HourClock user preference of device' owner.
 // ChromeOS device uses this setting on login screen.
 const char kSystemUse24HourClock[] = "cros.system.use_24hour_clock";
 
 const char kDeviceOwner[] = "cros.device.owner";
 
-const char kStatsReportingPref[] = "cros.metrics.reportingEnabled";

[Alexei Svitkine (slow), 2015/10/16 21:27:16]

I see a few more places that reference this in codesearch that I don't see in
your CL:

https://code.google.com/p/chromium/codesearch#search/&q=cros.metrics.reportin...

[gayane -on leave until 09-2017, 2015/10/19 21:32:39]

Thanks Alexei for pointing this out. 
The ones that were not in this Cl described below:
- policy_test_cases.json
    will do that at the same time with unittests within this Cl, if     
    this change will seem reasonable to reviewers
- prefs_util.cc
    removed the reference, but didn't add anything instead. Not sure     
    about this
- privacy_page.html
    according to previous conversations I had, a new privacy page        
    was getting designed however the development was stopped and 
    there are no plans. So I disregarded this file.

-
 const char kReleaseChannel[] = "cros.system.releaseChannel";
 const char kReleaseChannelDelegated[] = "cros.system.releaseChannelDelegated";
 
 // A boolean pref that indicates whether OS & firmware version info should be
 // reported along with device policy requests.
 const char kReportDeviceVersionInfo[] =
     "cros.device_status.report_version_info";
 
 // A boolean pref that indicates whether device activity times should be
 // recorded and reported along with device policy requests.
@@ skipping 86 matching lines @@
 // A boolean pref that indicates whether the device automatically reboots when
 // the user initiates a shutdown via an UI element.  If set to true, all
 // shutdown buttons in the UI will be replaced by reboot buttons.
 const char kRebootOnShutdown[] = "cros.device.reboot_on_shutdown";
 
 // An integer pref that specifies the limit of the device's extension cache
 // size in bytes.
 const char kExtensionCacheSize[] = "cros.device.extension_cache_size";
 
 }  // namespace chromeos