Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Side by Side Diff: chrome/browser/policy/configuration_policy_handler_list_factory.cc

Issue 1411863002: Use kMetricsReportingEnabled instead of kStatsReporingPref on metrics side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/policy/configuration_policy_handler_list_factory.h" 5 #include "chrome/browser/policy/configuration_policy_handler_list_factory.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/memory/scoped_vector.h" 9 #include "base/memory/scoped_vector.h"
10 #include "base/prefs/pref_value_map.h" 10 #include "base/prefs/pref_value_map.h"
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 base::Value::TYPE_BOOLEAN }, 115 base::Value::TYPE_BOOLEAN },
116 { key::kPasswordManagerAllowShowPasswords, 116 { key::kPasswordManagerAllowShowPasswords,
117 password_manager::prefs::kPasswordManagerAllowShowPasswords, 117 password_manager::prefs::kPasswordManagerAllowShowPasswords,
118 base::Value::TYPE_BOOLEAN }, 118 base::Value::TYPE_BOOLEAN },
119 { key::kPrintingEnabled, 119 { key::kPrintingEnabled,
120 prefs::kPrintingEnabled, 120 prefs::kPrintingEnabled,
121 base::Value::TYPE_BOOLEAN }, 121 base::Value::TYPE_BOOLEAN },
122 { key::kDisablePrintPreview, 122 { key::kDisablePrintPreview,
123 prefs::kPrintPreviewDisabled, 123 prefs::kPrintPreviewDisabled,
124 base::Value::TYPE_BOOLEAN }, 124 base::Value::TYPE_BOOLEAN },
125 { key::kMetricsReportingEnabled,
126 metrics::prefs::kMetricsReportingEnabled,
127 base::Value::TYPE_BOOLEAN },
128 { key::kApplicationLocaleValue, 125 { key::kApplicationLocaleValue,
129 prefs::kApplicationLocale, 126 prefs::kApplicationLocale,
130 base::Value::TYPE_STRING }, 127 base::Value::TYPE_STRING },
131 { key::kDisabledPlugins, 128 { key::kDisabledPlugins,
132 prefs::kPluginsDisabledPlugins, 129 prefs::kPluginsDisabledPlugins,
133 base::Value::TYPE_LIST }, 130 base::Value::TYPE_LIST },
134 { key::kDisabledPluginsExceptions, 131 { key::kDisabledPluginsExceptions,
135 prefs::kPluginsDisabledPluginsExceptions, 132 prefs::kPluginsDisabledPluginsExceptions,
136 base::Value::TYPE_LIST }, 133 base::Value::TYPE_LIST },
137 { key::kEnabledPlugins, 134 { key::kEnabledPlugins,
(...skipping 338 matching lines...) Expand 10 before | Expand all | Expand 10 after
476 prefs::kCaptivePortalAuthenticationIgnoresProxy, 473 prefs::kCaptivePortalAuthenticationIgnoresProxy,
477 base::Value::TYPE_BOOLEAN }, 474 base::Value::TYPE_BOOLEAN },
478 { key::kForceMaximizeOnFirstRun, 475 { key::kForceMaximizeOnFirstRun,
479 prefs::kForceMaximizeOnFirstRun, 476 prefs::kForceMaximizeOnFirstRun,
480 base::Value::TYPE_BOOLEAN }, 477 base::Value::TYPE_BOOLEAN },
481 { key::kUnifiedDesktopEnabledByDefault, 478 { key::kUnifiedDesktopEnabledByDefault,
482 prefs::kUnifiedDesktopEnabledByDefault, 479 prefs::kUnifiedDesktopEnabledByDefault,
483 base::Value::TYPE_BOOLEAN }, 480 base::Value::TYPE_BOOLEAN },
484 #endif // defined(OS_CHROMEOS) 481 #endif // defined(OS_CHROMEOS)
485 482
483 #if defined(OS_CHROMEOS)
Alexei Svitkine (slow) 2015/10/16 21:27:16 I think this could use a comment about the discrep
gayane -on leave until 09-2017 2015/10/19 21:32:39 Done.
484 { key::kDeviceMetricsReportingEnabled,
485 metrics::prefs::kMetricsReportingEnabled,
486 base::Value::TYPE_BOOLEAN },
487 #else
488 { key::kMetricsReportingEnabled,
489 metrics::prefs::kMetricsReportingEnabled,
490 base::Value::TYPE_BOOLEAN },
491 #endif
492
486 #if !defined(OS_MACOSX) && !defined(OS_CHROMEOS) 493 #if !defined(OS_MACOSX) && !defined(OS_CHROMEOS)
487 { key::kBackgroundModeEnabled, 494 { key::kBackgroundModeEnabled,
488 prefs::kBackgroundModeEnabled, 495 prefs::kBackgroundModeEnabled,
489 base::Value::TYPE_BOOLEAN }, 496 base::Value::TYPE_BOOLEAN },
490 #endif // !defined(OS_MACOSX) && !defined(OS_CHROMEOS) 497 #endif // !defined(OS_MACOSX) && !defined(OS_CHROMEOS)
491 498
492 #if defined(OS_ANDROID) 499 #if defined(OS_ANDROID)
493 { key::kDataCompressionProxyEnabled, 500 { key::kDataCompressionProxyEnabled,
494 data_reduction_proxy::prefs::kDataReductionProxyEnabled, 501 data_reduction_proxy::prefs::kDataReductionProxyEnabled,
495 base::Value::TYPE_BOOLEAN }, 502 base::Value::TYPE_BOOLEAN },
(...skipping 300 matching lines...) Expand 10 before | Expand all | Expand 10 after
796 SimpleSchemaValidatingPolicyHandler::RECOMMENDED_ALLOWED, 803 SimpleSchemaValidatingPolicyHandler::RECOMMENDED_ALLOWED,
797 SimpleSchemaValidatingPolicyHandler::MANDATORY_PROHIBITED))); 804 SimpleSchemaValidatingPolicyHandler::MANDATORY_PROHIBITED)));
798 handlers->AddHandler(make_scoped_ptr( 805 handlers->AddHandler(make_scoped_ptr(
799 new chromeos::KeyPermissionsPolicyHandler(chrome_schema))); 806 new chromeos::KeyPermissionsPolicyHandler(chrome_schema)));
800 #endif // defined(OS_CHROMEOS) 807 #endif // defined(OS_CHROMEOS)
801 808
802 return handlers.Pass(); 809 return handlers.Pass();
803 } 810 }
804 811
805 } // namespace policy 812 } // namespace policy
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698