Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4324)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateAlwaysPanel.java

Issue 1411853007: Begin adding class for laying out InfoBar controls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateAlwaysPanel.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateAlwaysPanel.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateAlwaysPanel.java
index e9023874ee8876625c250cfbe8f65e6a677d3a8f..506211ff05b15a1af1c04f5407de6454ef38d6a3 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateAlwaysPanel.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateAlwaysPanel.java
@@ -1,6 +1,7 @@
-// Copyright 2013 The Chromium Authors. All rights reserved.
+// Copyright 2015 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+
package org.chromium.chrome.browser.infobar;
import android.content.Context;
@@ -26,8 +27,7 @@ public class TranslateAlwaysPanel implements TranslateSubPanel {
R.string.translate_infobar_translation_done, mOptions.targetLanguage()));
if (!mOptions.triggeredFromMenu()) {
- TranslateCheckBox checkBox = new TranslateCheckBox(context, mOptions, mListener);
- layout.setCustomContent(checkBox);
+ layout.setCustomContent(createAlwaysToggle(context, mOptions));
}
layout.setButtons(context.getString(R.string.translate_button_done),
@@ -42,4 +42,16 @@ public class TranslateAlwaysPanel implements TranslateSubPanel {
mListener.onPanelClosed(ActionType.TRANSLATE_SHOW_ORIGINAL);
}
}
+
+ /**
+ * Creates a toggle that shows the current status of the "Always translate <language>" option.
+ */
+ static InfoBarControlLayout createAlwaysToggle(Context context, TranslateOptions options) {
+ InfoBarControlLayout controlLayout = new InfoBarControlLayout(context);
+ controlLayout.addSwitch(-1,
+ context.getString(R.string.translate_always_text, options.sourceLanguage()),
+ R.id.translate_infobar_always_toggle,
+ options.alwaysTranslateLanguageState());
+ return controlLayout;
+ }
}

Powered by Google App Engine
This is Rietveld 408576698