Begin adding class for laying out InfoBar controls

chrome/android/java/res/layout/infobar_subcontrol_toggle.xml

Index: chrome/android/java/res/layout/infobar_subcontrol_toggle.xml
diff --git a/chrome/android/java/res/layout/infobar_subcontrol_toggle.xml b/chrome/android/java/res/layout/infobar_subcontrol_toggle.xml
new file mode 100644
index 0000000000000000000000000000000000000000..d947b88d05faf388e6716e83b21f572f21b4b164
--- /dev/null
+++ b/chrome/android/java/res/layout/infobar_subcontrol_toggle.xml
@@ -0,0 +1,43 @@
+<?xml version="1.0" encoding="utf-8"?>

[newt (away), 2015/11/05 05:52:15]

If this is a "subcontrol" what is a "regular control"? I think we could do away
with the "sub" prefix and just call these "infobar controls". E.g.
infobar_control_toggle.xml, InfoBarControlLayout, etc

[gone, 2015/11/05 20:42:03]

Done.

+<!-- Copyright 2015 The Chromium Authors. All rights reserved.
+     Use of this source code is governed by a BSD-style license that can be
+     found in the LICENSE file. -->
+
+<LinearLayout
+    xmlns:android="http://schemas.android.com/apk/res/android"
+    android:id="@+id/subcontrol_toggle"
+    android:layout_width="match_parent"
+    android:layout_height="36dp">
+
+    <ImageView
+        android:id="@+id/subcontrol_toggle_icon"
+        android:layout_width="wrap_content"
+        android:layout_height="match_parent"
+        android:layout_weight="0"

[newt (away), 2015/11/05 05:52:15]

weight="0" is the default. I'd just leave it out, which is what we typically do.

[gone, 2015/11/05 20:42:03]

Done.

+        android:layout_gravity="center_vertical|start"

[newt (away), 2015/11/05 05:52:15]

"start" isn't needed here, and "end" isn't needed in the Switch, since the
TextView takes up all the extra space. (I believe "start" and "end" wouldn't
have any affect anyway, even if the TextView's width were a fixed value.)

[gone, 2015/11/05 20:42:03]

Done.

+        android:layout_marginEnd="8dp"
+        android:visibility="gone"
+        android:scaleType="centerInside"
+        android:contentDescription="@null" />
+
+    <TextView
+        android:id="@+id/subcontrol_toggle_message"
+        android:layout_width="0dp"
+        android:layout_height="match_parent"
+        android:layout_weight="1"
+        android:layout_gravity="center_vertical"

[newt (away), 2015/11/05 05:52:15]

Instead of adding layout_gravity="center_vertical" to all the children, you can
add gravity="center_vertical" to the LinearLayout. Either's fine though.

[gone, 2015/11/05 20:42:03]

Done.

+        android:gravity="center_vertical"
+        android:lineSpacingExtra="@dimen/infobar_subcontrol_text_extra_spacing"

[newt (away), 2015/11/05 05:52:16]

I'd recommend lineSpacingMultiplier instead of lineSpacingExtra so that the line
spacing still looks good when the device font size is set to tiny or HUGE.

[gone, 2015/11/05 20:42:03]

Going with 1.4 instead of 1.428, assuming dp=sp and 20/14 is the ratio the
designers were hoping for.

+        android:textDirection="locale"

[newt (away), 2015/11/05 05:52:16]

Use textAlignment instead of textDirection. textDirection will force LTR text to
be rendered as RTL, which rearranges the text and makes a general mess of things
if the text is actually LTR. textAlignment merely aligns the text to the left
(resp. right) side of the view, which is what we want.

textDirection is truly problematic when the text comes from the user (e.g. we
used it once on the bookmarks page, which caused rather hilarious problems). But
in general we should avoid it unless it's really needed (as in infobar_text.xml,
where we want to force text like "maps.google.com אָלֶף־בֵּית עִבְרִי
אָלֶף־בֵּית עִבְרִי אָלֶף־בֵּית עִבְרִי" to be displayed as RTL.)

[gone, 2015/11/05 20:42:02]

Took it out.  Was copied over from the previous version of this toggle.

+        android:textSize="@dimen/infobar_subcontrol_text_size"
+        android:textColor="@color/default_text_color" />
+
+    <Switch
+        android:id="@+id/subcontrol_toggle_switch"
+        android:layout_width="wrap_content"
+        android:layout_height="match_parent"
+        android:layout_weight="0"
+        android:layout_gravity="center_vertical|end"
+        android:layout_marginStart="16dp" />
+
+</LinearLayout>