chrome/android/java/res/layout/infobar_control_toggle.xml - Issue 1411853007: Begin adding class for laying out InfoBar controls

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/infobar_control_toggle.xml

Issue 1411853007: Begin adding class for laying out InfoBar controls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <LinearLayout

	7 xmlns:android="http://schemas.android.com/apk/res/android"

	8 android:id="@+id/subcontrol_toggle"

	9 android:layout_width="match_parent"

	10 android:layout_height="36dp"

	11 android:gravity="center_vertical">

	12

	13 <ImageView

	14 android:id="@+id/control_toggle_icon"

	15 android:layout_width="wrap_content"
	newt (away) 2015/11/05 22:07:44 Don't you need layout_height? Don't you need layout_height? gone 2015/11/05 22:21:38 ugh rebasing Show quoted text On 2015/11/05 22:07:44, newt wrote: > Don't you need layout_height? ugh rebasing
	16 android:layout_gravity="center_vertical"

	17 android:layout_marginEnd="8dp"

	18 android:scaleType="centerInside"

	19 android:contentDescription="@null" />

	20

	21 <TextView

	22 android:id="@+id/control_toggle_message"

	23 android:layout_width="0dp"

	24 android:layout_height="match_parent"

	25 android:layout_weight="1"

	26 android:layout_gravity="center_vertical"
	newt (away) 2015/11/05 22:07:44 remove this remove this gone 2015/11/05 22:21:38 Done. Show quoted text On 2015/11/05 22:07:44, newt wrote: > remove this Done.
	27 android:gravity="center_vertical"

	28 android:lineSpacingMultiplier="1.4"

	29 android:textSize="@dimen/infobar_control_text_size"

	30 android:textColor="@color/default_text_color" />

	31

	32 <Switch

	33 android:id="@+id/control_toggle_switch"

	34 android:layout_width="wrap_content"

	35 android:layout_height="match_parent"

	36 android:layout_marginStart="16dp" />

	37

	38 </LinearLayout>

OLD	NEW

« no previous file with comments | « no previous file | chrome/android/java/res/values/dimens.xml » ('j') | chrome/android/java/res/values/ids.xml » ('J')