[Telemetry] Close msr server win after checking whether platform can monitor power.

[Telemetry] Close msr server win after checking whether platform can monitor power.

BUG=549562
Committed: https://crrev.com/1bcb1f15179af6a7f901c5e85ea50b76a0f9c1d2
Cr-Commit-Position: refs/heads/master@{#358649}

[nednguyen, 2015-11-09 18:06:40]

nednguyen@google.com changed reviewers:
+ dtu@chromium.org

[dtu, 2015-11-09 18:13:25]

https://codereview.chromium.org/1411843011/diff/1/tools/telemetry/telemetry/i...
File
tools/telemetry/telemetry/internal/platform/power_monitor/msr_power_monitor.py
(right):

https://codereview.chromium.org/1411843011/diff/1/tools/telemetry/telemetry/i...
tools/telemetry/telemetry/internal/platform/power_monitor/msr_power_monitor.py:137:
# Since _CheckMSRs() start the MSR server, we must close it after checking
nit: starts

https://codereview.chromium.org/1411843011/diff/1/tools/telemetry/telemetry/i...
tools/telemetry/telemetry/internal/platform/power_monitor/msr_power_monitor.py:139:
self._backend.CloseMsrServer()
We need to do so on both Linux and Win, so perhaps it's better inside
_CheckMSRs().

[nednguyen, 2015-11-09 18:16:44]

https://codereview.chromium.org/1411843011/diff/1/tools/telemetry/telemetry/i...
File
tools/telemetry/telemetry/internal/platform/power_monitor/msr_power_monitor.py
(right):

https://codereview.chromium.org/1411843011/diff/1/tools/telemetry/telemetry/i...
tools/telemetry/telemetry/internal/platform/power_monitor/msr_power_monitor.py:137:
# Since _CheckMSRs() start the MSR server, we must close it after checking
On 2015/11/09 18:13:24, dtu wrote:
> nit: starts

Done.

https://codereview.chromium.org/1411843011/diff/1/tools/telemetry/telemetry/i...
tools/telemetry/telemetry/internal/platform/power_monitor/msr_power_monitor.py:139:
self._backend.CloseMsrServer()
On 2015/11/09 18:13:25, dtu wrote:
> We need to do so on both Linux and Win, so perhaps it's better inside
> _CheckMSRs().

CloseMsrServer is win_platform_backend only, updated the comment to reflect
this.

[dtu, 2015-11-09 18:25:46]

lgtm. Thanks!

https://codereview.chromium.org/1411843011/diff/1/tools/telemetry/telemetry/i...
File
tools/telemetry/telemetry/internal/platform/power_monitor/msr_power_monitor.py
(right):

https://codereview.chromium.org/1411843011/diff/1/tools/telemetry/telemetry/i...
tools/telemetry/telemetry/internal/platform/power_monitor/msr_power_monitor.py:139:
self._backend.CloseMsrServer()
On 2015/11/09 18:16:44, nednguyen wrote:
> On 2015/11/09 18:13:25, dtu wrote:
> > We need to do so on both Linux and Win, so perhaps it's better inside
> > _CheckMSRs().
> 
> CloseMsrServer is win_platform_backend only, updated the comment to reflect
> this.

Ah, yes, your'e right.

[nednguyen, 2015-11-09 18:25:58]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2015-11-09 18:26:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411843011/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411843011/20001

[commit-bot: I haz the power, 2015-11-09 21:06:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-09 21:07:27]

Patchset 2 (id:??) landed as
https://crrev.com/1bcb1f15179af6a7f901c5e85ea50b76a0f9c1d2
Cr-Commit-Position: refs/heads/master@{#358649}