Make blink platform time consistent with the timer virtual time

Make blink platform time consistent with the timer virtual time

This patch doesn't change anything unless the --enable-virtualized-time
command line flag is specifed.  If it is specified it makes
monotonicallyIncreasingTime and currentTime use the virtual
time source which drives the timers.

Also rename BlinkPlatform's currentTIme to currentTimeSeconds and
monotonicallyIncreacingTime to monotonicallyIncreacingTimeSeconds.

BUG=546953
Committed: https://crrev.com/822562449e875d806b16d94fa4ee0167e2a2c78e
Cr-Commit-Position: refs/heads/master@{#358291}

[alex clarke (OOO till 29th), 2015-10-30 17:19:49]

alexclarke@chromium.org changed reviewers:
+ skyostil@chromium.org

[alex clarke (OOO till 29th), 2015-10-30 17:20:24]

Description was changed from

==========
Make virtual time consistant with blink platform time

This patch doesn't change anything unless the --enable-virtualized-time
command line flag is specifed.  If it is specifed it makes
monotonicallyIncreasingTime and currentTime be consistant with virtual
time source used to drive the timers.

BUG=546953
==========

to

==========
Make virtual time consistant with blink platform time

This patch doesn't change anything unless the --enable-virtualized-time
command line flag is specifed.  If it is specifed it makes
monotonicallyIncreasingTime and currentTime be consistant with virtual
time source used to drive the timers.

BUG=546953
==========

[alex clarke (OOO till 29th), 2015-10-30 17:20:35]

Description was changed from

==========
Make virtual time consistant with blink platform time

This patch doesn't change anything unless the --enable-virtualized-time
command line flag is specifed.  If it is specifed it makes
monotonicallyIncreasingTime and currentTime be consistant with virtual
time source used to drive the timers.

BUG=546953
==========

to

==========
Make blink platform time  consistant with the timer virtual time

This patch doesn't change anything unless the --enable-virtualized-time
command line flag is specifed.  If it is specifed it makes
monotonicallyIncreasingTime and currentTime be consistant with virtual
time source used to drive the timers.

BUG=546953
==========

[alex clarke (OOO till 29th), 2015-10-30 17:21:09]

Description was changed from

==========
Make blink platform time  consistant with the timer virtual time

This patch doesn't change anything unless the --enable-virtualized-time
command line flag is specifed.  If it is specifed it makes
monotonicallyIncreasingTime and currentTime be consistant with virtual
time source used to drive the timers.

BUG=546953
==========

to

==========
Make blink platform time  consistant with the timer virtual time

This patch doesn't change anything unless the --enable-virtualized-time
command line flag is specifed.  If it is specifed it makes
monotonicallyIncreasingTime and currentTime use the virtual
time source which drives the timers.

BUG=546953
==========

[alex clarke (OOO till 29th), 2015-10-30 17:21:23]

Description was changed from

==========
Make blink platform time  consistant with the timer virtual time

This patch doesn't change anything unless the --enable-virtualized-time
command line flag is specifed.  If it is specifed it makes
monotonicallyIncreasingTime and currentTime use the virtual
time source which drives the timers.

BUG=546953
==========

to

==========
Make blink platform time consistent with the timer virtual time

This patch doesn't change anything unless the --enable-virtualized-time
command line flag is specifed.  If it is specified it makes
monotonicallyIncreasingTime and currentTime use the virtual
time source which drives the timers.

BUG=546953
==========

[Sami, 2015-10-30 19:53:31]

lgtm with some nits.

https://codereview.chromium.org/1411843008/diff/1/components/scheduler/base/t...
File components/scheduler/base/task_queue_manager_delegate.h (right):

https://codereview.chromium.org/1411843008/diff/1/components/scheduler/base/t...
components/scheduler/base/task_queue_manager_delegate.h:34: virtual double
currentTime() const = 0;
Capital 'c'.

https://codereview.chromium.org/1411843008/diff/1/components/scheduler/render...
File components/scheduler/renderer/renderer_scheduler.h (right):

https://codereview.chromium.org/1411843008/diff/1/components/scheduler/render...
components/scheduler/renderer/renderer_scheduler.h:146: virtual double
currentTime() const = 0;
CurrentTime here too

Both of these could use some documentation by the way.

https://codereview.chromium.org/1411843008/diff/1/components/scheduler/render...
components/scheduler/renderer/renderer_scheduler.h:148: virtual double
monotonicallyIncreasingTime() const = 0;
MonotonicallyIncreasingTime

[alex clarke (OOO till 29th), 2015-11-04 15:12:24]

alexclarke@chromium.org changed reviewers:
+ jochen@chromium.org

[alex clarke (OOO till 29th), 2015-11-04 15:12:24]

+jochen@ can you please review the changes in content/renderer/

https://codereview.chromium.org/1411843008/diff/1/components/scheduler/base/t...
File components/scheduler/base/task_queue_manager_delegate.h (right):

https://codereview.chromium.org/1411843008/diff/1/components/scheduler/base/t...
components/scheduler/base/task_queue_manager_delegate.h:34: virtual double
currentTime() const = 0;
On 2015/10/30 19:53:31, Sami wrote:
> Capital 'c'.

Done.

https://codereview.chromium.org/1411843008/diff/1/components/scheduler/render...
File components/scheduler/renderer/renderer_scheduler.h (right):

https://codereview.chromium.org/1411843008/diff/1/components/scheduler/render...
components/scheduler/renderer/renderer_scheduler.h:146: virtual double
currentTime() const = 0;
On 2015/10/30 19:53:31, Sami wrote:
> CurrentTime here too
> 
> Both of these could use some documentation by the way.

Done.

https://codereview.chromium.org/1411843008/diff/1/components/scheduler/render...
components/scheduler/renderer/renderer_scheduler.h:148: virtual double
monotonicallyIncreasingTime() const = 0;
On 2015/10/30 19:53:31, Sami wrote:
> MonotonicallyIncreasingTime

Done.

[jochen (gone - plz use gerrit), 2015-11-05 01:25:23]

https://codereview.chromium.org/1411843008/diff/40001/content/renderer/render...
File content/renderer/renderer_blink_platform_impl.h (right):

https://codereview.chromium.org/1411843008/diff/40001/content/renderer/render...
content/renderer/renderer_blink_platform_impl.h:173: double currentTime()
override;
can you change these two methods (and the ones on renderer scheduler) to include
a unit?

currentTimeMilliseconds() or whatever the unit is?

[alex clarke (OOO till 29th), 2015-11-05 12:23:16]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-05 12:23:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411843008/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411843008/60001

[commit-bot: I haz the power, 2015-11-05 12:32:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-05 12:33:00]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[alex clarke (OOO till 29th), 2015-11-05 12:47:43]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-05 12:48:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411843008/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411843008/80001

[commit-bot: I haz the power, 2015-11-05 13:12:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-05 13:12:12]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[alex clarke (OOO till 29th), 2015-11-05 15:27:11]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[alex clarke (OOO till 29th), 2015-11-05 15:27:20]

PTAL

https://codereview.chromium.org/1411843008/diff/40001/content/renderer/render...
File content/renderer/renderer_blink_platform_impl.h (right):

https://codereview.chromium.org/1411843008/diff/40001/content/renderer/render...
content/renderer/renderer_blink_platform_impl.h:173: double currentTime()
override;
On 2015/11/05 01:25:23, jochen wrote:
> can you change these two methods (and the ones on renderer scheduler) to
include
> a unit?
> 
> currentTimeMilliseconds() or whatever the unit is?

This is a good idea.  Too bad we can't use base::TimeTicks in blink yet :(

[commit-bot: I haz the power, 2015-11-05 15:27:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411843008/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411843008/100001

[alex clarke (OOO till 29th), 2015-11-05 15:55:09]

Description was changed from

==========
Make blink platform time consistent with the timer virtual time

This patch doesn't change anything unless the --enable-virtualized-time
command line flag is specifed.  If it is specified it makes
monotonicallyIncreasingTime and currentTime use the virtual
time source which drives the timers.

BUG=546953
==========

to

==========
Make blink platform time consistent with the timer virtual time

This patch doesn't change anything unless the --enable-virtualized-time
command line flag is specifed.  If it is specified it makes
monotonicallyIncreasingTime and currentTime use the virtual
time source which drives the timers.

Also rename BlinkPlatform's currentTIme to currentTimeSeconds and
monotonicallyIncreacingTime to monotonicallyIncreacingTimeSeconds

BUG=546953
==========

[alex clarke (OOO till 29th), 2015-11-05 15:55:41]

Description was changed from

==========
Make blink platform time consistent with the timer virtual time

This patch doesn't change anything unless the --enable-virtualized-time
command line flag is specifed.  If it is specified it makes
monotonicallyIncreasingTime and currentTime use the virtual
time source which drives the timers.

Also rename BlinkPlatform's currentTIme to currentTimeSeconds and
monotonicallyIncreacingTime to monotonicallyIncreacingTimeSeconds

BUG=546953
==========

to

==========
Make blink platform time consistent with the timer virtual time

This patch doesn't change anything unless the --enable-virtualized-time
command line flag is specifed.  If it is specified it makes
monotonicallyIncreasingTime and currentTime use the virtual
time source which drives the timers.

Also rename BlinkPlatform's currentTIme to currentTimeSeconds and
monotonicallyIncreacingTime to monotonicallyIncreacingTimeSeconds.

BUG=546953
==========

[alex clarke (OOO till 29th), 2015-11-05 16:30:15]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-05 16:31:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411843008/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411843008/120001

[commit-bot: I haz the power, 2015-11-05 17:34:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-05 17:34:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[alex clarke (OOO till 29th), 2015-11-05 17:57:04]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-05 17:57:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411843008/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411843008/140001

[commit-bot: I haz the power, 2015-11-05 19:19:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-05 19:19:59]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[alex clarke (OOO till 29th), 2015-11-05 20:17:59]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-05 20:18:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411843008/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411843008/140001

[commit-bot: I haz the power, 2015-11-05 22:21:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-05 22:21:50]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[jochen (gone - plz use gerrit), 2015-11-06 05:45:07]

lgtm

[alex clarke (OOO till 29th), 2015-11-06 08:24:19]

The CQ bit was checked by alexclarke@chromium.org

[alex clarke (OOO till 29th), 2015-11-06 08:24:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/1411843008/#ps140001
(title: "Fix CachingCorrectnessTest")

[commit-bot: I haz the power, 2015-11-06 08:24:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411843008/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411843008/140001

[commit-bot: I haz the power, 2015-11-06 09:26:21]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-11-06 09:27:09]

Patchset 8 (id:??) landed as
https://crrev.com/822562449e875d806b16d94fa4ee0167e2a2c78e
Cr-Commit-Position: refs/heads/master@{#358291}