Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: mojo/dart/embedder/mojo_dart_state.h

Issue 1411843005: Dart: Removes C++ set for closing handles on an unhandled exception. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/dart/embedder/dart_controller.cc ('k') | mojo/dart/embedder/mojo_natives.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/dart/embedder/mojo_dart_state.h
diff --git a/mojo/dart/embedder/mojo_dart_state.h b/mojo/dart/embedder/mojo_dart_state.h
index adaa1d0793d890bd145544b0d22eee4b7fbbac77..773945abfc30aa4ca8bdd55e3b967a3b7306b8c5 100644
--- a/mojo/dart/embedder/mojo_dart_state.h
+++ b/mojo/dart/embedder/mojo_dart_state.h
@@ -19,7 +19,7 @@ namespace mojo {
namespace dart {
struct IsolateCallbacks {
- base::Callback<void(Dart_Handle)> exception;
+ base::Callback<void(Dart_Handle, int64_t)> exception;
};
// State associated with an isolate (retrieved via |Dart_CurrentIsolateData|).
@@ -43,14 +43,6 @@ class MojoDartState : public tonic::DartState {
const IsolateCallbacks& callbacks() const { return callbacks_; }
const std::string& script_uri() const { return script_uri_; }
const std::string& package_root() const { return package_root_; }
- std::set<MojoHandle>& unclosed_handles() {
- return unclosed_handles_;
- }
-
- const std::set<MojoHandle>& unclosed_handles() const {
- return unclosed_handles_;
- }
-
void set_library_provider(tonic::DartLibraryProvider* library_provider) {
library_provider_.reset(library_provider);
@@ -99,7 +91,6 @@ class MojoDartState : public tonic::DartState {
IsolateCallbacks callbacks_;
std::string script_uri_;
std::string package_root_;
- std::set<MojoHandle> unclosed_handles_;
std::unique_ptr<tonic::DartLibraryProvider> library_provider_;
mojo::NetworkServicePtr network_service_;
};
« no previous file with comments | « mojo/dart/embedder/dart_controller.cc ('k') | mojo/dart/embedder/mojo_natives.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698