XFA: Manually apply changes to fpdf_text.h and fx_font.h from master

XFA: Manually apply changes to fpdf_text.h and fx_font.h from master

Driven off of https://codereview.chromium.org/1398383002/

Then make the other files as similar as possible.  Note that this
required changes to xfa/ code, and required adding some Set() methods.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/1b04bcc6af13669920700322052fc4ab4fad47a2

[Tom Sepez, 2015-10-23 19:14:59]

Description was changed from

==========
XFA: Manually apply changes to fpdf_text.h and fx_font.h from master

Then make the other files as similar as possible.  Note that this
required changes to xfa/ code, and required adding some Set() methods.
==========

to

==========
XFA: Manually apply changes to fpdf_text.h and fx_font.h from master

Driven off of https://codereview.chromium.org/1398383002/

Then make the other files as similar as possible.  Note that this
required changes to xfa/ code, and required adding some Set() methods.
==========

[Tom Sepez, 2015-10-23 19:14:59]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2015-10-23 19:21:41]

Lei, for review.

[Lei Zhang, 2015-10-23 19:32:52]

lgtm, I guess I forgot to merge a CL somewhere.

https://codereview.chromium.org/1411833003/diff/1/xfa/src/fgas/src/font/fx_ge...
File xfa/src/fgas/src/font/fx_gefont.cpp (right):

https://codereview.chromium.org/1411833003/diff/1/xfa/src/fgas/src/font/fx_ge...
xfa/src/fgas/src/font/fx_gefont.cpp:361: if (m_pFont->GetSubstFont() == NULL) {
!foo, and below too.

[Tom Sepez, 2015-10-23 19:34:00]

On 2015/10/23 19:32:52, Lei Zhang wrote:
> lgtm, I guess I forgot to merge a CL somewhere.
> 
Yeah, I looked, and these changes are from before the reformat, so it won't
apply anyways.

[Tom Sepez, 2015-10-23 19:37:49]

Committed patchset #2 (id:20001) manually as
1b04bcc6af13669920700322052fc4ab4fad47a2 (presubmit successful).

[Tom Sepez, 2015-10-23 19:40:47]

https://codereview.chromium.org/1411833003/diff/1/xfa/src/fgas/src/font/fx_ge...
File xfa/src/fgas/src/font/fx_gefont.cpp (right):

https://codereview.chromium.org/1411833003/diff/1/xfa/src/fgas/src/font/fx_ge...
xfa/src/fgas/src/font/fx_gefont.cpp:361: if (m_pFont->GetSubstFont() == NULL) {
On 2015/10/23 19:32:52, Lei Zhang wrote:
> !foo, and below too.

Done.