Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 1411833002: Remove obsolete flag to enable package support (Closed)

Created:
5 years, 2 months ago by Brian Wilkerson
Modified:
5 years, 2 months ago
Reviewers:
pquitslund
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -80 lines) Patch
M pkg/analysis_server/lib/src/context_manager.dart View 5 chunks +47 lines, -75 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
The class ServerOptions appears to be unused. Should I remove it as well?
5 years, 2 months ago (2015-10-16 17:46:45 UTC) #2
pquitslund
On 2015/10/16 17:46:45, Brian Wilkerson wrote: > The class ServerOptions appears to be unused. Should ...
5 years, 2 months ago (2015-10-16 19:46:13 UTC) #3
pquitslund
LGTM!
5 years, 2 months ago (2015-10-16 19:46:24 UTC) #4
Brian Wilkerson
5 years, 2 months ago (2015-10-16 20:43:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
adb8ebd0e67d10fadb4e2cc9ba55c1347e80cfa4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698