content/browser/loader/navigation_url_loader_unittest.cc - Issue 1411813003: Teach URLRequest about initiator checks for First-Party-Only cookies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/navigation_url_loader_unittest.cc

Issue 1411813003: Teach URLRequest about initiator checks for First-Party-Only cookies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Feedback. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/navigation_request_info.cc ('k') | content/browser/loader/resource_dispatcher_host_impl.cc » ('j') | content/browser/loader/resource_dispatcher_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/loader/navigation_url_loader_unittest.cc

diff --git a/content/browser/loader/navigation_url_loader_unittest.cc b/content/browser/loader/navigation_url_loader_unittest.cc

index 5c4c7fdfe2a8bb6fe78f59f2f61465fd0e02c1ef..9d7c3ff7d682e6f608ab2e5dca8cbd9e809ec328 100644

--- a/content/browser/loader/navigation_url_loader_unittest.cc

+++ b/content/browser/loader/navigation_url_loader_unittest.cc

@@ -34,6 +34,7 @@

#include "net/url_request/url_request_test_job.h"

#include "net/url_request/url_request_test_util.h"

#include "testing/gtest/include/gtest/gtest.h"

+#include "url/origin.h"

namespace content {

@@ -183,9 +184,9 @@ class NavigationURLLoaderTest : public testing::Test {

REQUEST_CONTEXT_TYPE_LOCATION);

CommonNavigationParams common_params;

common_params.url = url;

- scoped_ptr<NavigationRequestInfo> request_info(

- new NavigationRequestInfo(common_params, begin_params, url, true, false,

- -1, scoped_refptr<ResourceRequestBody>()));

+ scoped_ptr<NavigationRequestInfo> request_info(new NavigationRequestInfo(

+ common_params, begin_params, url, url::Origin(url), true, false, -1,

+ scoped_refptr<ResourceRequestBody>()));

return NavigationURLLoader::Create(browser_context_.get(),

request_info.Pass(), delegate);