Chromium Code Reviews| Index: content/browser/frame_host/navigation_request.cc |
| diff --git a/content/browser/frame_host/navigation_request.cc b/content/browser/frame_host/navigation_request.cc |
| index 94f061ad1f3236a509801b56c99981317f673394..d3640f280914cf95a2d9ef696f9b874e2e483b43 100644 |
| --- a/content/browser/frame_host/navigation_request.cc |
| +++ b/content/browser/frame_host/navigation_request.cc |
| @@ -174,6 +174,10 @@ NavigationRequest::NavigationRequest( |
| frame_tree_node->current_frame_host()->GetSiteInstance(); |
| } |
| + // TODO(mkwst): This is incorrect. It ought to use the definition from |
| + // 'Document::firstPartyForCookies()' in Blink, which walks the ancestor tree |
| + // and verifies that all origins are PSL-matches (and special-cases extension |
| + // URLs). |
|
nasko
2015/10/20 22:36:30
Is this TODO going to be addressed in this CL?
Mike West
2015/10/22 13:17:02
No. It's just something I noticed in passing.
|
| const GURL& first_party_for_cookies = |
| frame_tree_node->IsMainFrame() |
| ? common_params.url |
| @@ -182,8 +186,8 @@ NavigationRequest::NavigationRequest( |
| false : frame_tree_node->parent()->IsMainFrame(); |
| info_.reset(new NavigationRequestInfo( |
| common_params, begin_params, first_party_for_cookies, |
| - frame_tree_node->IsMainFrame(), parent_is_main_frame, |
| - frame_tree_node->frame_tree_node_id(), body)); |
| + frame_tree_node->frame_origin(), frame_tree_node->IsMainFrame(), |
| + parent_is_main_frame, frame_tree_node->frame_tree_node_id(), body)); |
| } |
| NavigationRequest::~NavigationRequest() { |