Teach URLRequest about initiator checks for First-Party-Only cookies.

net/cookies/cookie_options.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Brought to you by number 42.
 
 #ifndef NET_COOKIES_COOKIE_OPTIONS_H_
 #define NET_COOKIES_COOKIE_OPTIONS_H_
 
 #include "base/time/time.h"
 #include "net/base/net_export.h"
 #include "url/gurl.h"
 #include "url/origin.h"

[mmenke, 2015/10/21 15:36:38]

Don't need the last two of these any more.

 
 namespace net {
 
 class NET_EXPORT CookieOptions {
  public:
   // Default is to exclude httponly completely, and exclude first-party from
   // being read, which means:
   // - reading operations will not return httponly or first-party cookies.
   // - writing operations will not write httponly cookies (first-party will be
   // written).
   //
   // If a first-party URL is set, then first-party cookies which match that URL
   // will be returned.
   CookieOptions();
 
   void set_exclude_httponly() { exclude_httponly_ = true; }
   void set_include_httponly() { exclude_httponly_ = false; }
   bool exclude_httponly() const { return exclude_httponly_; }
 
   void set_include_first_party_only() { include_first_party_only_ = true; }
   bool include_first_party_only() const { return include_first_party_only_; }

[mmenke, 2015/10/21 15:36:38]

Can we rename this to "include_first_party_only_cookies", and add documentation?

This was confusing me because it sounds like "include first party cookies,
only".

[Mike West, 2015/10/22 13:17:02]

Sure. Done.

 
-  void set_first_party(const url::Origin& origin) { first_party_ = origin; }
-  const url::Origin& first_party() const { return first_party_; }
-
   // TODO(estark): Remove once we decide whether to ship cookie
   // prefixes. https://crbug.com/541511
   void set_enforce_prefixes() { enforce_prefixes_ = true; }
   bool enforce_prefixes() const { return enforce_prefixes_; }
 
   // |server_time| indicates what the server sending us the Cookie thought the
   // current time was when the cookie was produced.  This is used to adjust for
   // clock skew between server and host.
   void set_server_time(const base::Time& server_time) {
     server_time_ = server_time;
   }
   bool has_server_time() const { return !server_time_.is_null(); }
   base::Time server_time() const { return server_time_; }
 
  private:
   bool exclude_httponly_;
   bool include_first_party_only_;
-  url::Origin first_party_;
   bool enforce_prefixes_;
   base::Time server_time_;
 };
 
 }  // namespace net
 
 #endif  // NET_COOKIES_COOKIE_OPTIONS_H_