Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 14118010: Fixed flickering thumbnails in Files.app on Drive. (Closed)

Created:
7 years, 8 months ago by mtomasz
Modified:
7 years, 8 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Fixed flickering thumbnails in Files.app on Drive. The flickering was caused by missing argument in ThumbnailLoader.load(). As a result, callbacks were passed in wrong order, and an error callback was passed in place of the success callback. That caused interpreting each success as an error, which caused refreshing of the directory to retrieve new metadata. TEST=Launch Files.app, go to Drive, click on any picture. Thumbnail should not be flickering every second. BUG=226758 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195126

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/resources/file_manager/js/file_grid.js View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
mtomasz
@yoshiki: Ping.
7 years, 8 months ago (2013-04-18 10:09:24 UTC) #1
mtomasz
On 2013/04/18 10:09:24, mtomasz wrote: > @yoshiki: Ping. @yoshiki: Ping. This is a M27 Pri-1 ...
7 years, 8 months ago (2013-04-19 01:14:49 UTC) #2
yoshiki
lgtm
7 years, 8 months ago (2013-04-19 01:34:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/14118010/1
7 years, 8 months ago (2013-04-19 01:51:48 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=136694
7 years, 8 months ago (2013-04-19 04:28:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/14118010/1
7 years, 8 months ago (2013-04-19 09:03:40 UTC) #6
mtomasz
7 years, 8 months ago (2013-04-19 09:21:33 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r195126 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698