Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Issue 14118006: Change owner of DriveScheduler from DriveFileSystem to DriveSystemService. (Closed)

Created:
7 years, 8 months ago by kinaba
Modified:
7 years, 8 months ago
Reviewers:
satorux1
CC:
chromium-reviews, nkostylev+watch_chromium.org, tfarina, oshima+watch_chromium.org, tzik+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Change owner of DriveScheduler from DriveFileSystem to DriveSystemService. DriveSystemService exposes only the JobListInterface of DriveScheduler. BUG=128079 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194734

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -37 lines) Patch
M chrome/browser/chromeos/drive/drive_file_system.h View 1 3 chunks +3 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_file_system.cc View 1 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_file_system_unittest.cc View 5 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_scheduler.h View 1 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_scheduler.cc View 2 chunks +2 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_scheduler_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_system_service.h View 1 4 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_system_service.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/create_directory_operation_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/stale_cache_files_remover_unittest.cc View 4 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kinaba
7 years, 8 months ago (2013-04-17 02:00:28 UTC) #1
satorux1
LGTM
7 years, 8 months ago (2013-04-17 03:35:23 UTC) #2
kinaba
7 years, 8 months ago (2013-04-18 00:20:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r194734 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698