Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1411793006: Generalize python_git_runner for use in non-git scripts. (Closed)

Created:
5 years, 1 month ago by Michael Moss
Modified:
5 years, 1 month ago
Reviewers:
iannucci1, estaab, iannucci, sky1
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, sky1
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Generalize python_git_runner for use in non-git scripts. Retrying the change in https://codereview.chromium.org/1415993003/, with fixes to properly handle being called with either Windows- or POSIX-style paths (the previous attempt assumed it was always called with POSIX-style paths under MSYS, which itself was attempting to fix the assumption that it was always called with Windows-style paths, but neither assumption was right). This change doesn't actually use the wrapper in any new places, but subsequent changes will be made to use it in places where 'exec python' is called directly, like gclient and fetch. BUG=411518 R=iannucci@google.com, sky@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297401

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -58 lines) Patch
M git-auto-svn View 1 chunk +1 line, -1 line 0 comments Download
M git-cache View 1 chunk +1 line, -1 line 0 comments Download
M git-cherry-pick-upload View 1 chunk +1 line, -1 line 0 comments Download
M git-cl View 1 chunk +1 line, -1 line 0 comments Download
M git-drover View 1 chunk +1 line, -1 line 0 comments Download
M git-find-releases View 1 chunk +1 line, -1 line 0 comments Download
M git-footers View 1 chunk +1 line, -1 line 0 comments Download
M git-freeze View 1 chunk +1 line, -1 line 0 comments Download
M git-map View 1 chunk +1 line, -1 line 0 comments Download
M git-map-branches View 1 chunk +1 line, -1 line 0 comments Download
M git-mark-merge-base View 1 chunk +1 line, -1 line 0 comments Download
M git-nav-downstream View 1 chunk +1 line, -1 line 0 comments Download
M git-new-branch View 1 chunk +1 line, -1 line 0 comments Download
M git-number View 1 chunk +1 line, -1 line 0 comments Download
M git-rebase-update View 1 chunk +1 line, -1 line 0 comments Download
M git-rename-branch View 1 chunk +1 line, -1 line 0 comments Download
M git-reparent-branch View 1 chunk +1 line, -1 line 0 comments Download
M git-retry View 1 chunk +1 line, -1 line 0 comments Download
M git-squash-branch View 1 chunk +1 line, -1 line 0 comments Download
M git-thaw View 1 chunk +1 line, -1 line 0 comments Download
M git-try View 1 chunk +1 line, -1 line 0 comments Download
M git-upstream-diff View 1 chunk +1 line, -1 line 0 comments Download
D python_git_runner.sh View 1 chunk +0 lines, -36 lines 0 comments Download
A python_runner.sh View 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Michael Moss
5 years, 1 month ago (2015-10-28 21:37:23 UTC) #1
Michael Moss
+estaab as trooper
5 years, 1 month ago (2015-10-29 16:47:04 UTC) #3
estaab
lgtm
5 years, 1 month ago (2015-10-29 16:47:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411793006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411793006/1
5 years, 1 month ago (2015-10-29 16:50:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_presubmit/builds/237)
5 years, 1 month ago (2015-10-29 16:55:39 UTC) #8
Michael Moss
Ugh, still needs OWNER LGTM.
5 years, 1 month ago (2015-10-29 16:56:52 UTC) #9
iannucci
scary :( lgtm
5 years, 1 month ago (2015-10-30 01:13:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411793006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411793006/1
5 years, 1 month ago (2015-10-30 15:37:30 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 15:39:26 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297401

Powered by Google App Engine
This is Rietveld 408576698