Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Issue 1411783009: Revert of Roll android_tools deps (Closed)

Created:
5 years, 1 month ago by dcaiafa
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll android_tools deps (patchset #4 id:60001 of https://codereview.chromium.org/1419533002/ ) Reason for revert: Potential cause of break: http://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%206%29/builds/3804 Original issue's description: > Roll android_tools deps > > Sets the build-tools version. > Renames two resources due to resource name clashes with mediarouter > resources > Adds recyclerview as a dependency to design in gn. > > BUG=537270 > > Committed: https://crrev.com/8356eb404a31149079621a7fe95e79bea4c9fb3e > Cr-Commit-Position: refs/heads/master@{#356346} TBR=dfalcantara@chromium.org,aurimas@chromium.org,jbudorick@chromium.org,yusufo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=537270 Committed: https://crrev.com/de6b09140fd5cbf679ddbbe37d206848ab15d421 Cr-Commit-Position: refs/heads/master@{#356360}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -24 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/constants/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/config/android/config.gni View 1 chunk +1 line, -1 line 0 comments Download
M build/secondary/third_party/android_tools/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
A chrome/android/java/res/drawable-hdpi/ic_collapse.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/ic_collapsed.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-hdpi/ic_expand.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/ic_expanded.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-mdpi/ic_collapse.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/ic_collapsed.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-mdpi/ic_expand.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/ic_expanded.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/ic_collapse.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/ic_collapsed.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/ic_expand.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/ic_expanded.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxhdpi/ic_collapse.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/ic_collapsed.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxhdpi/ic_expand.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/ic_expanded.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxxhdpi/ic_collapse.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/ic_collapsed.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxxhdpi/ic_expand.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/ic_expanded.png View Binary file 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsGroupView.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java View 2 chunks +4 lines, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java View 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dcaiafa
Created Revert of Roll android_tools deps
5 years, 1 month ago (2015-10-27 19:03:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411783009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411783009/1
5 years, 1 month ago (2015-10-27 19:05:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-27 19:07:31 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 19:09:42 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de6b09140fd5cbf679ddbbe37d206848ab15d421
Cr-Commit-Position: refs/heads/master@{#356360}

Powered by Google App Engine
This is Rietveld 408576698