Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1411783004: More timeline cleanups (Closed)

Created:
5 years, 2 months ago by Cutch
Modified:
5 years, 2 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

More timeline cleanups - Blocks are associated with threads and not isolates. - Fix isolate filters when iterating over blocks and events. - Always add the isolateNumber argument when serializing events. - Add new (kSerializedJSON) EventType for events already serialized to JSON. - Have events coming from Dart code use the standard event structure w/ type = kSerializedJSON. - Remove now unused DartTimelineEvent and machinary. - Dart and C++ events now use the same structures and system. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/f55de246ec2bc62d34223c4046d73a8ca1d9a4d2

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -472 lines) Patch
M runtime/lib/timeline.cc View 1 2 6 chunks +28 lines, -9 lines 0 comments Download
M runtime/lib/timeline.dart View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 2 3 4 4 chunks +10 lines, -67 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/json_stream.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/json_stream.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/timeline.h View 1 2 3 18 chunks +25 lines, -101 lines 0 comments Download
M runtime/vm/timeline.cc View 1 2 3 4 26 chunks +54 lines, -283 lines 0 comments Download
M runtime/vm/timeline_analysis.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/timeline_test.cc View 1 2 3 4 chunks +11 lines, -4 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/developer_patch.dart View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M sdk/lib/developer/timeline.dart View 1 2 4 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Cutch
5 years, 2 months ago (2015-10-19 18:04:14 UTC) #4
rmacnak
lgtm
5 years, 2 months ago (2015-10-19 19:24:33 UTC) #5
Cutch
5 years, 2 months ago (2015-10-20 16:14:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
f55de246ec2bc62d34223c4046d73a8ca1d9a4d2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698