Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1411763004: fix yvu constants for avx2 yuv to rgb (Closed)

Created:
5 years, 1 month ago by fbarchard1
Modified:
5 years, 1 month ago
Reviewers:
harryjin, fbarchard
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

fix yvu constants for avx2 yuv to rgb the yvu matrix for yuv to rgb had an incorrect entry, affecting yuv to bgra, yuv to abgr and yuv to raw. fix the matrix and reenable avx2 functions. R=harryjin@google.com BUG=libyuv:522 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/6100f50f136829b9769baf79306b31e0665ec16a

Patch Set 1 #

Patch Set 2 : disable 64 bit specific avx2 #

Patch Set 3 : fix another yvu constant for avx2 #

Patch Set 4 : reenable avx2 64 bit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -17 lines) Patch
M README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/row.h View 2 chunks +7 lines, -9 lines 0 comments Download
M include/libyuv/version.h View 1 chunk +1 line, -1 line 0 comments Download
M source/row_common.cc View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M unit_test/convert_test.cc View 1 chunk +74 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
fbarchard1
5 years, 1 month ago (2015-11-10 18:26:11 UTC) #1
harryjin
lgtm
5 years, 1 month ago (2015-11-10 18:27:45 UTC) #2
fbarchard
[----------] Global test environment tear-down [==========] 973 tests from 6 test cases ran. (1905 ms ...
5 years, 1 month ago (2015-11-10 18:45:30 UTC) #4
fbarchard1
5 years, 1 month ago (2015-11-10 18:45:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
6100f50f136829b9769baf79306b31e0665ec16a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698