Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 1411763002: dart2js cps: Ensure parameter default values are emitted. (Closed)

Created:
5 years, 2 months ago by asgerf
Modified:
5 years, 2 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Ensure parameter default values are emitted. BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/ee0f98ab335e9d6acfdf897c0cd0984a654d5d3a

Patch Set 1 #

Patch Set 2 : Update status #

Patch Set 3 : Remove empty section from status file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -8 lines) Patch
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 2 chunks +19 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/glue.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/language/language_dart2js.status View 1 1 chunk +0 lines, -1 line 0 comments Download
M tests/standalone/standalone.status View 1 2 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
asgerf
5 years, 2 months ago (2015-10-16 12:47:57 UTC) #2
sra1
lgtm
5 years, 2 months ago (2015-10-16 14:52:02 UTC) #3
asgerf
5 years, 2 months ago (2015-10-16 15:00:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
ee0f98ab335e9d6acfdf897c0cd0984a654d5d3a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698