Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1411733004: Fix ARGBToI411 odd width bug. (Closed)

Created:
5 years, 2 months ago by fbarchard1
Modified:
5 years, 2 months ago
Reviewers:
harryjin
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Fix ARGBToI411 odd width bug. The any function for handling ARGBToI411 was not handling the pixel replication correctly. On 422 and odd width was handled by duplicating a pixel of source. 411 needs replication for remainders of 1, 2 or 3 pixels. The C version was handling odd width but with an average of the remainder pixels, which does not match the SIMD 'any' handling off remainder. This changes the odd width handling to mimic the any version. TBR=harryjin@google.com BUG=libyuv:491 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/ba4b409d51c24bbb64650bbf40bbf23994e36532

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -6 lines) Patch
M README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/version.h View 1 chunk +1 line, -1 line 0 comments Download
M source/row_any.cc View 1 chunk +17 lines, -1 line 0 comments Download
M source/row_common.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
fbarchard1
5 years, 2 months ago (2015-10-21 19:19:26 UTC) #1
fbarchard1
5 years, 2 months ago (2015-10-21 19:22:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ba4b409d51c24bbb64650bbf40bbf23994e36532 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698