Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1411723007: Remove --harmony-new-target flag (Closed)

Created:
5 years, 1 month ago by adamk
Modified:
5 years, 1 month ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove --harmony-new-target flag It was shipped in M46 without incident. Committed: https://crrev.com/720c531a701d40ae489794546a7638a5349f972a Cr-Commit-Position: refs/heads/master@{#31636}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -427 lines) Patch
M src/bootstrapper.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/flag-definitions.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/parser.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/preparser.h View 1 4 chunks +1 line, -4 lines 0 comments Download
M src/scopes.cc View 1 3 chunks +3 lines, -5 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M test/message/new-target-assignment.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/message/new-target-assignment.out View 1 chunk +1 line, -1 line 0 comments Download
M test/message/new-target-for-loop.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/message/new-target-for-loop.out View 1 chunk +1 line, -1 line 0 comments Download
M test/message/new-target-postfix-op.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/message/new-target-postfix-op.out View 1 chunk +1 line, -1 line 0 comments Download
M test/message/new-target-prefix-op.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/message/new-target-prefix-op.out View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/new-target.js View 1 chunk +1 line, -2 lines 0 comments Download
D test/mjsunit/harmony/new-target.js View 1 chunk +0 lines, -398 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
adamk
5 years, 1 month ago (2015-10-28 01:04:21 UTC) #2
rossberg
lgtm
5 years, 1 month ago (2015-10-28 14:42:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411723007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411723007/1
5 years, 1 month ago (2015-10-28 15:56:06 UTC) #5
commit-bot: I haz the power
Failed to apply patch for src/bootstrapper.cc: While running git apply --index -3 -p1; error: patch ...
5 years, 1 month ago (2015-10-28 15:58:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411723007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411723007/20001
5 years, 1 month ago (2015-10-28 16:15:09 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-28 16:46:40 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 16:47:17 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/720c531a701d40ae489794546a7638a5349f972a
Cr-Commit-Position: refs/heads/master@{#31636}

Powered by Google App Engine
This is Rietveld 408576698