Make SkTextBlob::RunIterator public.

Make SkTextBlob::RunIterator public.

Motivation: This will be easier than adding a friend every time I want
to create a one-off SkCanvas subclass or SkRemote::Encoder subclass.

See also: SkPath::Iter.

Committed: https://skia.googlesource.com/skia/+/337797580de42cdb722caab4bed121311ed7d0d2

[hal.canary, 2015-10-27 19:42:27]

halcanary@google.com changed reviewers:
+ fmalita@chromium.org, reed@google.com

[hal.canary, 2015-10-27 19:42:27]

PTAL

[hal.canary, 2015-10-27 19:53:28]

How is this?

[hal.canary, 2015-10-27 19:53:54]

Patchset #2 (id:20001) has been deleted

[mtklein, 2015-10-27 19:57:35]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2015-10-27 19:57:36]

(lgtm)

[reed1, 2015-10-27 20:07:52]

api lgtm

[f(malita), 2015-10-27 20:10:00]

https://codereview.chromium.org/1411723005/diff/10002/include/core/SkTextBlob.h
File include/core/SkTextBlob.h (right):

https://codereview.chromium.org/1411723005/diff/10002/include/core/SkTextBlob...
include/core/SkTextBlob.h:54: class RunIterator;
Since the definition is internal-only, it seems a bit odd for the decl to be
public.

Wouldn't it work to befriend the iterator and just drop the decl here?

[mtklein, 2015-10-27 20:14:31]

https://codereview.chromium.org/1411723005/diff/10002/include/core/SkTextBlob.h
File include/core/SkTextBlob.h (right):

https://codereview.chromium.org/1411723005/diff/10002/include/core/SkTextBlob...
include/core/SkTextBlob.h:54: class RunIterator;
On 2015/10/27 20:10:00, f(malita) wrote:
> Since the definition is internal-only, it seems a bit odd for the decl to be
> public.
> 
> Wouldn't it work to befriend the iterator and just drop the decl here?

Both work.  It's mostly a question of whether you want it named
SkTextBlob::RunIterator or SkTextBlobRunIterator.

[hal.canary, 2015-10-27 20:22:38]

On 2015/10/27 20:10:00, f(malita) wrote:
>
https://codereview.chromium.org/1411723005/diff/10002/include/core/SkTextBlob.h
> File include/core/SkTextBlob.h (right):
> 
>
https://codereview.chromium.org/1411723005/diff/10002/include/core/SkTextBlob...
> include/core/SkTextBlob.h:54: class RunIterator;
> Since the definition is internal-only, it seems a bit odd for the decl to be
> public.
> 
> Wouldn't it work to befriend the iterator and just drop the decl here?

Done.  It's just a slightly larger patch this way.

[mtklein, 2015-10-27 20:25:15]

On 2015/10/27 20:22:38, Hal Canary wrote:
> On 2015/10/27 20:10:00, f(malita) wrote:
> >
>
https://codereview.chromium.org/1411723005/diff/10002/include/core/SkTextBlob.h
> > File include/core/SkTextBlob.h (right):
> > 
> >
>
https://codereview.chromium.org/1411723005/diff/10002/include/core/SkTextBlob...
> > include/core/SkTextBlob.h:54: class RunIterator;
> > Since the definition is internal-only, it seems a bit odd for the decl to be
> > public.
> > 
> > Wouldn't it work to befriend the iterator and just drop the decl here?
> 
> Done.  It's just a slightly larger patch this way.

Personally I prefer PS2, but PS3 lgtm too.

[f(malita), 2015-10-27 20:43:53]

On 2015/10/27 20:25:15, mtklein wrote:
> On 2015/10/27 20:22:38, Hal Canary wrote:
> > On 2015/10/27 20:10:00, f(malita) wrote:
> > >
> >
>
https://codereview.chromium.org/1411723005/diff/10002/include/core/SkTextBlob.h
> > > File include/core/SkTextBlob.h (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1411723005/diff/10002/include/core/SkTextBlob...
> > > include/core/SkTextBlob.h:54: class RunIterator;
> > > Since the definition is internal-only, it seems a bit odd for the decl to
be
> > > public.
> > > 
> > > Wouldn't it work to befriend the iterator and just drop the decl here?
> > 
> > Done.  It's just a slightly larger patch this way.
> 
> Personally I prefer PS2, but PS3 lgtm too.

LGTM too, for either PS (now that I've made you do extra work :P)

[hal.canary, 2015-10-27 20:45:15]

The CQ bit was checked by halcanary@google.com

[hal.canary, 2015-10-27 20:45:15]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1411723005/#ps50001
(title: "2015-10-27 (Tuesday) 16:20:53 EDT")

[commit-bot: I haz the power, 2015-10-27 20:45:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411723005/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411723005/50001

[commit-bot: I haz the power, 2015-10-27 21:01:09]

Committed patchset #3 (id:50001) as
https://skia.googlesource.com/skia/+/337797580de42cdb722caab4bed121311ed7d0d2