Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1411713004: [heap] Add detailed timers to --trace-gc-nvp MC marking phase. (Closed)

Created:
5 years, 2 months ago by Hannes Payer (out of office)
Modified:
5 years, 2 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Add detailed timers to --trace-gc-nvp MC marking phase. BUG= Committed: https://crrev.com/c5479518e089d48399117228868c743eed13bbb3 Cr-Commit-Position: refs/heads/master@{#31344}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -44 lines) Patch
M src/heap/gc-tracer.h View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M src/heap/gc-tracer.cc View 1 2 3 chunks +41 lines, -15 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 3 chunks +66 lines, -29 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Hannes Payer (out of office)
5 years, 2 months ago (2015-10-16 14:10:11 UTC) #2
ulan
lgtm https://codereview.chromium.org/1411713004/diff/20001/src/heap/gc-tracer.h File src/heap/gc-tracer.h (right): https://codereview.chromium.org/1411713004/diff/20001/src/heap/gc-tracer.h#newcode102 src/heap/gc-tracer.h:102: MC_MARK_INC, Let's find a more descriptive name for ...
5 years, 2 months ago (2015-10-16 14:18:31 UTC) #3
Hannes Payer (out of office)
https://codereview.chromium.org/1411713004/diff/20001/src/heap/gc-tracer.h File src/heap/gc-tracer.h (right): https://codereview.chromium.org/1411713004/diff/20001/src/heap/gc-tracer.h#newcode102 src/heap/gc-tracer.h:102: MC_MARK_INC, On 2015/10/16 14:18:31, ulan wrote: > Let's find ...
5 years, 2 months ago (2015-10-16 14:24:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411713004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411713004/40001
5 years, 2 months ago (2015-10-16 14:25:03 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-16 15:41:32 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 15:41:54 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c5479518e089d48399117228868c743eed13bbb3
Cr-Commit-Position: refs/heads/master@{#31344}

Powered by Google App Engine
This is Rietveld 408576698