Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1411693006: Make LayoutImageResource::image() parameter explicit (Closed)

Created:
5 years, 1 month ago by davve
Modified:
5 years, 1 month ago
Reviewers:
fs
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make LayoutImageResource::image() parameter explicit It makes the code more explicit and easier to read. No functional change expected. BUG=551419 Committed: https://crrev.com/3059b983258e55aeacef6e0b04bdd35a72436d3b Cr-Commit-Position: refs/heads/master@{#358287}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Avoid RefPtr churn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImageResource.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImageResource.cpp View 1 2 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ImagePainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/SVGImagePainter.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411693006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411693006/1
5 years, 1 month ago (2015-11-05 14:27:37 UTC) #2
davve
5 years, 1 month ago (2015-11-05 14:29:02 UTC) #4
fs
LGTM /w nit https://codereview.chromium.org/1411693006/diff/1/third_party/WebKit/Source/core/layout/LayoutImageResource.cpp File third_party/WebKit/Source/core/layout/LayoutImageResource.cpp (right): https://codereview.chromium.org/1411693006/diff/1/third_party/WebKit/Source/core/layout/LayoutImageResource.cpp#newcode110 third_party/WebKit/Source/core/layout/LayoutImageResource.cpp:110: RefPtr<Image> image = m_cachedImage ? m_cachedImage->image() ...
5 years, 1 month ago (2015-11-05 15:05:54 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/126761)
5 years, 1 month ago (2015-11-05 15:28:30 UTC) #7
davve
https://codereview.chromium.org/1411693006/diff/1/third_party/WebKit/Source/core/layout/LayoutImageResource.cpp File third_party/WebKit/Source/core/layout/LayoutImageResource.cpp (right): https://codereview.chromium.org/1411693006/diff/1/third_party/WebKit/Source/core/layout/LayoutImageResource.cpp#newcode110 third_party/WebKit/Source/core/layout/LayoutImageResource.cpp:110: RefPtr<Image> image = m_cachedImage ? m_cachedImage->image() : Image::nullImage(); On ...
5 years, 1 month ago (2015-11-06 07:36:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411693006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411693006/20001
5 years, 1 month ago (2015-11-06 07:36:52 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-06 08:47:39 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/3059b983258e55aeacef6e0b04bdd35a72436d3b Cr-Commit-Position: refs/heads/master@{#358287}
5 years, 1 month ago (2015-11-06 08:48:18 UTC) #13
davve
5 years, 1 month ago (2015-11-08 15:33:22 UTC) #14
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1431973002/ by davve@opera.com.

The reason for reverting is: Seems to have caused 553045.

Powered by Google App Engine
This is Rietveld 408576698