Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1411693005: Make AndroidOptions const (Closed)

Created:
5 years, 1 month ago by scroggo_chromium
Modified:
5 years, 1 month ago
Reviewers:
msarett, scroggo, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make AndroidOptions const Make the struct passed to SkAndroidCodec::getAndroidPixels const. This matches SkCodec, and makes sense, since it is not used as an output. Brought up in crrev.com/1417583009 Committed: https://skia.googlesource.com/skia/+/e95a06883b6d9972ea58c4e16f772bb88af393e9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M include/codec/SkAndroidCodec.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/codec/SkAndroidCodec.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/codec/SkSampledCodec.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/codec/SkSampledCodec.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/codec/SkWebpAdapterCodec.h View 1 chunk +1 line, -1 line 0 comments Download
M src/codec/SkWebpAdapterCodec.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
scroggo_chromium
Mike, can you look over this API change? Nothing else has changed.
5 years, 1 month ago (2015-11-03 21:18:30 UTC) #2
msarett
lgtm
5 years, 1 month ago (2015-11-03 21:20:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411693005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411693005/1
5 years, 1 month ago (2015-11-03 21:32:24 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/3670)
5 years, 1 month ago (2015-11-03 21:33:39 UTC) #7
reed1
always in favor of more restrictive/defensive apis lgtm
5 years, 1 month ago (2015-11-03 21:34:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411693005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411693005/1
5 years, 1 month ago (2015-11-03 21:48:17 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 12:31:14 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e95a06883b6d9972ea58c4e16f772bb88af393e9

Powered by Google App Engine
This is Rietveld 408576698