Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 1411683009: Update StringPrintfTest.Invalid for VS 2015 (Closed)

Created:
5 years, 1 month ago by brucedawson
Modified:
5 years, 1 month ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, jshin+watch_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update StringPrintfTest.Invalid for VS 2015 VS 2015's vswprintf handles invalid unicode differently from VS 2013. The usage of vswprintf through SStringPrintf and friends has been audited and this change should not be a problem, so the test has been changed to let it pass instead of blocking the compiler upgrade. R=cpu@chromium.org BUG=533002, 440500 Committed: https://crrev.com/4f5d484cfe4e2bb268dd479b6fbc23963aac564b Cr-Commit-Position: refs/heads/master@{#357964}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M base/strings/stringprintf_unittest.cc View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
brucedawson
This test fails on VS 2015, but there is no indication that this matters. The ...
5 years, 1 month ago (2015-11-03 21:58:48 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
5 years, 1 month ago (2015-11-05 00:43:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411683009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411683009/1
5 years, 1 month ago (2015-11-05 00:44:35 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-05 01:05:50 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 01:06:33 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f5d484cfe4e2bb268dd479b6fbc23963aac564b
Cr-Commit-Position: refs/heads/master@{#357964}

Powered by Google App Engine
This is Rietveld 408576698