Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 1411663012: Fix formatting specifier for MSVC++ 2013 compatibility. (Closed)

Created:
5 years, 1 month ago by miu
Modified:
5 years, 1 month ago
Reviewers:
brucedawson
CC:
chromium-reviews, imcheng+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, feature-media-reviews_chromium.org, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix formatting specifier for MSVC++ 2013 compatibility. The use of %zu in a printf format string is non-standard. This change is a follow-up to https://codereview.chromium.org/1417873007 to use the standard PRIuS macro instead. BUG=519022 TBR=brucedawson@chromium.org Committed: https://crrev.com/1dbefc62bf1df69475bea39c5a41f7825c72a6b0 Cr-Commit-Position: refs/heads/master@{#357582}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M media/cast/sender/external_video_encoder.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
miu
5 years, 1 month ago (2015-11-03 05:14:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411663012/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411663012/1
5 years, 1 month ago (2015-11-03 05:14:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/135054)
5 years, 1 month ago (2015-11-03 07:32:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411663012/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411663012/1
5 years, 1 month ago (2015-11-03 18:25:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-03 19:51:59 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1dbefc62bf1df69475bea39c5a41f7825c72a6b0 Cr-Commit-Position: refs/heads/master@{#357582}
5 years, 1 month ago (2015-11-03 19:52:41 UTC) #11
tommycli
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1414883010/ by tommycli@chromium.org. ...
5 years, 1 month ago (2015-11-05 00:48:49 UTC) #12
tommycli
On 2015/11/05 00:48:49, tommycli wrote: > A revert of this CL (patchset #1 id:1) has ...
5 years, 1 month ago (2015-11-05 00:49:37 UTC) #13
brucedawson
5 years, 1 month ago (2015-11-05 20:55:05 UTC) #14
Message was sent while issue was closed.
It is unfortunate that the crash call stacks don't include symbols. Not having
that information makes this diagnosis extremely difficult when it should be
trivial.

Powered by Google App Engine
This is Rietveld 408576698