Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: cc/debug/micro_benchmark_controller_unittest.cc

Issue 1411663002: cc: Split Proxy to eliminate unnecessary dependencies on the impl side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/callback.h" 5 #include "base/callback.h"
6 #include "base/memory/scoped_ptr.h" 6 #include "base/memory/scoped_ptr.h"
7 #include "cc/debug/micro_benchmark.h" 7 #include "cc/debug/micro_benchmark.h"
8 #include "cc/debug/micro_benchmark_controller.h" 8 #include "cc/debug/micro_benchmark_controller.h"
9 #include "cc/layers/layer.h" 9 #include "cc/layers/layer.h"
10 #include "cc/test/fake_impl_thread_verifier.h"
10 #include "cc/test/fake_layer_tree_host.h" 11 #include "cc/test/fake_layer_tree_host.h"
11 #include "cc/test/fake_layer_tree_host_impl.h" 12 #include "cc/test/fake_layer_tree_host_impl.h"
12 #include "cc/test/fake_proxy.h"
13 #include "cc/test/test_task_graph_runner.h" 13 #include "cc/test/test_task_graph_runner.h"
14 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
15 15
16 namespace cc { 16 namespace cc {
17 namespace { 17 namespace {
18 18
19 class MicroBenchmarkControllerTest : public testing::Test { 19 class MicroBenchmarkControllerTest : public testing::Test {
20 public: 20 public:
21 MicroBenchmarkControllerTest() 21 MicroBenchmarkControllerTest()
22 : layer_tree_host_client_(FakeLayerTreeHostClient::DIRECT_3D) {} 22 : layer_tree_host_client_(FakeLayerTreeHostClient::DIRECT_3D) {}
23 23
24 void SetUp() override { 24 void SetUp() override {
25 impl_proxy_ = make_scoped_ptr(new FakeImplProxy); 25 impl_thread_verifier_ = make_scoped_ptr(new FakeImplThreadVerifier);
26 layer_tree_host_impl_ = make_scoped_ptr(new FakeLayerTreeHostImpl( 26 layer_tree_host_impl_ = make_scoped_ptr(new FakeLayerTreeHostImpl(
27 impl_proxy_.get(), &shared_bitmap_manager_, &task_graph_runner_)); 27 impl_thread_verifier_.get(), &shared_bitmap_manager_,
28 &task_graph_runner_));
28 29
29 layer_tree_host_ = FakeLayerTreeHost::Create(&layer_tree_host_client_, 30 layer_tree_host_ = FakeLayerTreeHost::Create(&layer_tree_host_client_,
30 &task_graph_runner_); 31 &task_graph_runner_);
31 layer_tree_host_->SetRootLayer(Layer::Create(LayerSettings())); 32 layer_tree_host_->SetRootLayer(Layer::Create(LayerSettings()));
32 layer_tree_host_->InitializeForTesting(scoped_ptr<Proxy>(new FakeProxy)); 33 layer_tree_host_->InitializeForTesting(scoped_ptr<Proxy>(new FakeProxy));
33 } 34 }
34 35
35 void TearDown() override { 36 void TearDown() override {
36 layer_tree_host_impl_ = nullptr; 37 layer_tree_host_impl_ = nullptr;
37 layer_tree_host_ = nullptr; 38 layer_tree_host_ = nullptr;
38 impl_proxy_ = nullptr; 39 impl_thread_verifier_ = nullptr;
39 } 40 }
40 41
41 FakeLayerTreeHostClient layer_tree_host_client_; 42 FakeLayerTreeHostClient layer_tree_host_client_;
42 TestTaskGraphRunner task_graph_runner_; 43 TestTaskGraphRunner task_graph_runner_;
43 TestSharedBitmapManager shared_bitmap_manager_; 44 TestSharedBitmapManager shared_bitmap_manager_;
44 scoped_ptr<FakeLayerTreeHost> layer_tree_host_; 45 scoped_ptr<FakeLayerTreeHost> layer_tree_host_;
45 scoped_ptr<FakeLayerTreeHostImpl> layer_tree_host_impl_; 46 scoped_ptr<FakeLayerTreeHostImpl> layer_tree_host_impl_;
46 scoped_ptr<FakeImplProxy> impl_proxy_; 47 scoped_ptr<FakeImplThreadVerifier> impl_thread_verifier_;
47 }; 48 };
48 49
49 void Noop(scoped_ptr<base::Value> value) { 50 void Noop(scoped_ptr<base::Value> value) {
50 } 51 }
51 52
52 void IncrementCallCount(int* count, scoped_ptr<base::Value> value) { 53 void IncrementCallCount(int* count, scoped_ptr<base::Value> value) {
53 ++(*count); 54 ++(*count);
54 } 55 }
55 56
56 TEST_F(MicroBenchmarkControllerTest, ScheduleFail) { 57 TEST_F(MicroBenchmarkControllerTest, ScheduleFail) {
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
168 // Send invalid message to valid benchmark 169 // Send invalid message to valid benchmark
169 message = make_scoped_ptr(new base::DictionaryValue); 170 message = make_scoped_ptr(new base::DictionaryValue);
170 message->SetBoolean("can_handle", false); 171 message->SetBoolean("can_handle", false);
171 message_handled = 172 message_handled =
172 layer_tree_host_->SendMessageToMicroBenchmark(id, message.Pass()); 173 layer_tree_host_->SendMessageToMicroBenchmark(id, message.Pass());
173 EXPECT_FALSE(message_handled); 174 EXPECT_FALSE(message_handled);
174 } 175 }
175 176
176 } // namespace 177 } // namespace
177 } // namespace cc 178 } // namespace cc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698