Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1411653003: Remove register keyword from xfa files (Closed)

Created:
5 years, 1 month ago by Tom Sepez
Modified:
5 years, 1 month ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Remove register keyword from xfa files These are generating compilation warnings. R=dsinclair@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/5a88b1131c450dee0500a02f80f0838385e4c4d2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -28 lines) Patch
M xfa/src/fgas/src/crt/fx_memory.cpp View 17 chunks +25 lines, -25 lines 0 comments Download
M xfa/src/fgas/src/crt/fx_stream.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Dan, nothing but sed.
5 years, 1 month ago (2015-10-29 18:17:45 UTC) #2
dsinclair
lgtm
5 years, 1 month ago (2015-10-29 18:30:09 UTC) #3
Tom Sepez
5 years, 1 month ago (2015-10-29 19:29:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5a88b1131c450dee0500a02f80f0838385e4c4d2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698