Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1411653002: Install iterator meta objects via utils object. (Closed)

Created:
5 years, 2 months ago by Yang
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Install iterator meta objects via utils object. R=cbruni@chromium.org, hpayer@chromium.org Committed: https://crrev.com/30715157fa2959880dae93c9735cc687d0536a1e Cr-Commit-Position: refs/heads/master@{#31331}

Patch Set 1 #

Total comments: 3

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -324 lines) Patch
M src/bootstrapper.cc View 1 13 chunks +141 lines, -118 lines 0 comments Download
M src/heap/heap.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/js/array.js View 2 chunks +5 lines, -0 lines 0 comments Download
M src/js/array-iterator.js View 2 chunks +2 lines, -1 line 0 comments Download
M src/js/collection.js View 1 chunk +5 lines, -5 lines 0 comments Download
M src/js/collection-iterator.js View 1 3 chunks +2 lines, -2 lines 0 comments Download
M src/js/generator.js View 1 chunk +2 lines, -0 lines 0 comments Download
M src/js/harmony-array.js View 2 chunks +2 lines, -0 lines 0 comments Download
M src/js/harmony-array-includes.js View 2 chunks +6 lines, -1 line 0 comments Download
M src/js/iterator-prototype.js View 2 chunks +2 lines, -3 lines 0 comments Download
M src/js/macros.py View 1 chunk +2 lines, -2 lines 0 comments Download
M src/js/prologue.js View 4 chunks +9 lines, -7 lines 0 comments Download
M src/js/regexp.js View 1 chunk +2 lines, -0 lines 0 comments Download
M src/js/runtime.js View 2 chunks +2 lines, -7 lines 0 comments Download
M src/js/string-iterator.js View 2 chunks +2 lines, -1 line 0 comments Download
M src/js/v8natives.js View 6 chunks +11 lines, -16 lines 0 comments Download
M test/cctest/test-heap.cc View 2 chunks +6 lines, -5 lines 0 comments Download
D test/mjsunit/builtins.js View 1 chunk +0 lines, -109 lines 0 comments Download
D test/mjsunit/global-deleted-property-keyed.js View 1 chunk +0 lines, -38 lines 0 comments Download
M test/mjsunit/harmony/simd.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-3281.js View 1 chunk +4 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-403292.js View 2 chunks +4 lines, -2 lines 0 comments Download
M test/mjsunit/samevalue.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Yang
5 years, 2 months ago (2015-10-16 07:06:10 UTC) #1
Yang
Hannes, please look at the change to src/heap/heap.h
5 years, 2 months ago (2015-10-16 07:06:34 UTC) #2
Hannes Payer (out of office)
heap lgtm
5 years, 2 months ago (2015-10-16 08:07:51 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411653002/1
5 years, 2 months ago (2015-10-16 08:13:31 UTC) #5
Camillo Bruni
LGTM with very minor nits ;) https://codereview.chromium.org/1411653002/diff/1/src/bootstrapper.cc File src/bootstrapper.cc (right): https://codereview.chromium.org/1411653002/diff/1/src/bootstrapper.cc#newcode1876 src/bootstrapper.cc:1876: // The utils ...
5 years, 2 months ago (2015-10-16 08:34:01 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-16 09:06:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411653002/20001
5 years, 2 months ago (2015-10-16 11:03:51 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-16 11:27:20 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 11:27:38 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/30715157fa2959880dae93c9735cc687d0536a1e
Cr-Commit-Position: refs/heads/master@{#31331}

Powered by Google App Engine
This is Rietveld 408576698