Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1411643004: Revert of Suppress memory leak from WebGraphicsContext3DCommandBufferImpl (Closed)

Created:
5 years, 1 month ago by oshima
Modified:
5 years, 1 month ago
Reviewers:
erikchen, reveman
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Suppress memory leak from WebGraphicsContext3DCommandBufferImpl (patchset #1 id:20001 of https://codereview.chromium.org/1428643002/ ) Reason for revert: for speculative revert Original issue's description: > Suppress memory leak from WebGraphicsContext3DCommandBufferImpl > > BUG=548039 > TBR=erikchen@chromium.org,reveman@chromium.org > > Committed: https://crrev.com/fb1a837f472bc9f004ccb8fa1c0d5f83acbeba4e > Cr-Commit-Position: refs/heads/master@{#356444} TBR=erikchen@chromium.org,reveman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=548039 Committed: https://crrev.com/eca678585491d769a57eb41b34cb0b79a8e050f0 Cr-Commit-Position: refs/heads/master@{#356524}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M tools/valgrind/drmemory/suppressions_full.txt View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
oshima
Created Revert of Suppress memory leak from WebGraphicsContext3DCommandBufferImpl
5 years, 1 month ago (2015-10-28 07:41:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411643004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411643004/1
5 years, 1 month ago (2015-10-28 07:42:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-28 07:42:36 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/eca678585491d769a57eb41b34cb0b79a8e050f0 Cr-Commit-Position: refs/heads/master@{#356524}
5 years, 1 month ago (2015-10-28 07:43:29 UTC) #4
oshima
5 years, 1 month ago (2015-10-28 07:47:44 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1427733002/ by oshima@chromium.org.

The reason for reverting is: Couldn't do speculative revert due to conflict.
I'll look into other CLs first..

Powered by Google App Engine
This is Rietveld 408576698