Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1411633008: perf: moving to tracebd (Closed)

Created:
5 years, 1 month ago by jcgregorio
Modified:
5 years ago
Reviewers:
stephana
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@ts
Target Ref:
refs/heads/master
Visibility:
Public.

Description

perf: move to tracebd instead of filetilestore. DO NOT SUBMIT BUG=skia: Committed: https://skia.googlesource.com/buildbot/+/7b57a279720a6e6033cf66b54c8648cd50aa9dc2

Patch Set 1 #

Patch Set 2 : clean #

Patch Set 3 : finish #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Total comments: 2

Patch Set 6 : rename #

Patch Set 7 : vet #

Patch Set 8 : fix nil bug #

Patch Set 9 : fix alerting #

Patch Set 10 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -83 lines) Patch
M go/trace/db/db.go View 1 2 3 4 5 6 7 8 9 3 chunks +8 lines, -2 lines 0 comments Download
M perf/go/alerting/alerting.go View 1 2 3 4 5 6 7 8 5 chunks +9 lines, -18 lines 0 comments Download
M perf/go/skiaperf/main.go View 1 2 3 4 5 6 7 8 9 13 chunks +17 lines, -56 lines 0 comments Download
M perf/go/stats/stats.go View 1 2 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
jcgregorio
5 years, 1 month ago (2015-10-30 18:51:57 UTC) #3
stephana
lgtm with one comment https://codereview.chromium.org/1411633008/diff/80001/perf/go/alerting/alerting.go File perf/go/alerting/alerting.go (right): https://codereview.chromium.org/1411633008/diff/80001/perf/go/alerting/alerting.go#newcode15 perf/go/alerting/alerting.go:15: tdb "go.skia.org/infra/go/trace/db" nit: tracedb is ...
5 years, 1 month ago (2015-11-02 01:43:21 UTC) #4
jcgregorio
https://codereview.chromium.org/1411633008/diff/80001/perf/go/alerting/alerting.go File perf/go/alerting/alerting.go (right): https://codereview.chromium.org/1411633008/diff/80001/perf/go/alerting/alerting.go#newcode15 perf/go/alerting/alerting.go:15: tdb "go.skia.org/infra/go/trace/db" Done. On 2015/11/02 at 01:43:21, stephana wrote: ...
5 years, 1 month ago (2015-11-02 17:56:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411633008/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411633008/100001
5 years, 1 month ago (2015-11-02 17:56:33 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Infra-PerCommit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/Infra-PerCommit-Trybot/builds/1801)
5 years, 1 month ago (2015-11-02 18:03:32 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411633008/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411633008/100001
5 years, 1 month ago (2015-11-02 18:14:12 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411633008/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411633008/120001
5 years, 1 month ago (2015-11-02 18:14:52 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-02 18:16:42 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411633008/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411633008/180001
5 years ago (2015-11-28 15:33:29 UTC) #19
commit-bot: I haz the power
5 years ago (2015-11-28 15:36:09 UTC) #21
Message was sent while issue was closed. 
Committed patchset #10 (id:180001) as
https://skia.googlesource.com/buildbot/+/7b57a279720a6e6033cf66b54c8648cd50aa...

Powered by Google App Engine
This is Rietveld 408576698