Issue 1411633006: Include cmath so we get std::isnan

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1411633006: Include cmath so we get std::isnan (Closed)

Created:
5 years, 1 month ago by dsinclair

Modified:
5 years, 1 month ago

Reviewers:
Lei Zhang, Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Include cmath so we get std::isnan We need to include the <cmath> header so std::isnan exists. BUG=pdfium:250 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/aad3828aea84b504f98ddc94a11d88907f3144d9

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	xfa/src/fxbarcode/utils.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

LGTM (you could have TBR'd this since its a compilation breakage).

5 years, 1 month ago (2015-10-28 16:54:32 UTC) #3

dsinclair

5 years, 1 month ago (2015-10-28 17:00:59 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
aad3828aea84b504f98ddc94a11d88907f3144d9 (presubmit successful).